[Feature] Updating dgl ROCm support#20
Conversation
|
Adding @jamesETsmith as a reviewer |
|
Thanks for this @gcapodagAMD! There's some overlap between this and #16. I'm just getting back from leave and I'm trying clean up #16 now. As soon as that's landed, I'll take a look at this. In the meantime, could you tell us how you were building from source? What versions of rocm, python, and pytorch you were using? |
|
of course @jamesETsmith it was ROCm 7.2.0, Python3.10 on Ubuntu 22.04 and PyTorch 2.9.1. sorry, it looks like my latest commit still did not satisfy the linting requirements |
|
ok linting passing now |
|
@jamesETsmith I compared what is here with what is in the PR you mentioned and it looks like the files in |
|
also this one |
gcapodagAMD
left a comment
There was a problem hiding this comment.
let me know if you are happy with the changes or would like to request more, thanks
gcapodagAMD
left a comment
There was a problem hiding this comment.
I think I will be addressing all the left over comments with the next commit, thanks @jamesETsmith and @GMNGeoffrey
jamesETsmith
left a comment
There was a problem hiding this comment.
Just a few minor comments left
Description
Updating the support for ROCm
I have been in touch with @diptorupd who is aware of this PR. This comes from having to include updates to build dgl from source with ROCm support, to enable users at a hackathon in the UK.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes