fix(preflight): configurable l2ping ssh_timeout (Helios-R 180s abort) - #383
Open
speriaswamy-amd wants to merge 2 commits into
Open
fix(preflight): configurable l2ping ssh_timeout (Helios-R 180s abort)#383speriaswamy-amd wants to merge 2 commits into
speriaswamy-amd wants to merge 2 commits into
Conversation
Half-cabled afmctl sweeps exceed the hardcoded 180s cap and prune healthy nodes; expose ssh_timeout (default 600s) and loss_threshold_pct so operators can override. Co-authored-by: Cursor <cursoragent@cursor.com>
cijohnson
reviewed
Sep 1, 2026
cijohnson
requested changes
Sep 2, 2026
Customer JSON should name the PSSH read_timeout, not DEFAULT_SSH_TIMEOUT_SEC. The checker still takes ssh_timeout internally. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ssh_timeout=180andloss_threshold_pct=0.0. Schema only allowedenabled+pings_per_port, so operators could not override.afmctl test ping -c 3often runs ~2–4 min per invocation (half-cabled / failing dst accelerators). That exceeds 180s, so PSSH killed the sweep and pruned the node even when the fabric was still producing tables.afmctl -titself defaults to 5 minutes.ssh_timeout(default 600s) andloss_threshold_pctfirst-classconnectivity_check.ifoe.l2pingkeys, wires them throughIfoeL2ConnectivityCheck, and shows the timeout on the preflight HTML report.Test plan
test_ifoe_l2_connectivity.py(schema accept/reject, config wiring, default 600s)ssh_timeout=600— slow invocations completed (~4 min); pytest-html recorded 600s. Remaining FAIL is fabric (port 33 + ~50% full-mesh loss), not the timeout.Made with Cursor