Update FMHA calls with new MX qscale related args#2008
Draft
Conversation
CK_TILE FMHA new args: * seqstart_v_scale_ptr * stride_q_descale * stride_k_descale * stride_v_descale See ROCm/rocm-libraries#4368
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ROCm/rocm-libraries#4368 adds these new args for CK_TILE FMHA:
Technical Details
These update the relevant code to match the new API. None of the args and
quant_scale_enum::mxare actually used by Aiter.Caution
CK has moved to the monorepo while Aiter still uses the old separate repo as a submodule.
This PR does not include a new hash for
3rdparty/composable_kernelso it must not be merged before updating Aiter for monorepo!Test Plan
Run the following tests to check that
aiter/op_tests/test_mha.pyaiter/op_tests/test_mha_varlen.pyThe tests have been run manually because of monorepo.
Test Result
The existing tests work as usual.
Submission Checklist