Sync up with master branch#1024
Open
jkottiku wants to merge 365 commits into
Open
Conversation
jkottiku
requested review from
a team,
frepaul and
manoj-freyr
as code owners
September 30, 2025 17:30
yugang-amd
approved these changes
Sep 30, 2025
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
1 similar comment
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
build!: bump cmake_minimum_required to 3.5.0
refactor!: migrate to python3
chore: pwd does not take non-option parameters
Each time build is done packages created should be uploaded to AWS S3 bucket for PR builds.
Upload only if build is triggered from rocm/rocm-validation-suite Release files uploaded to rocm-validation-suite/release Nightly files uploaded to rocm-vlaidation-suite/nightly Pulish S3 link in build summary
No need to upload tar file from both the builds. Taking manylinux binaries as the base for install anywhere case. Need to added externaly depedency that can cause execution failure if installed on OS that do not have the required third-party libs
Both rpm/deb packages need repo metadata to be used as repo to install packages using apt/yum/dnf install
Starting ROCm 7.12 rocm pacakges have changed names. Newer RVS continue to work with old ROCm and new as well provided dependent libraries are connected with LD_LIBRARY_PATH/ldconf. Need to make sure RVS is installable with old or new method of ROCm installed in the system. Ref:https://github.com/ROCm/TheRock/blob/main/ docs/rfcs/RFC0009-OS-Packaging-Requirements.md
Signed-off-by: Urvashi Tiwari <urtiwari.com>
…y test pipeline Signed-off-by: Urvashi Tiwari <urtiwari.com>
Edited the nightly run to only run when schedule and on PUSH
Synchronizing Transferbench build to be same cmake parameters as the one in its pipeline. Enable LOG as well to check if the right GPU_TARGETS are passed and built for.
GPU_TARGET not getting parsed as a list and hence not all targets getting added to the build. Moving the implementation to list as one cache variable rather that list parsing to ensure all targets are correctly passed.
Signed-off-by: Urvashi Tiwari <urtiwari.com>
Signed-off-by: Urvashi Tiwari <urtiwari.com>
Signed-off-by: Urvashi Tiwari <urtiwari.com>
For some reason finding GCN path from ROCm is casuing issue on github runner.Trying a different approach and do error reporting for future debug.
ROCm 7.15 onwards added tarball with tests as pacakge with -tests- added to the name before version. Current logic downloads that and fail to fetch the ROCm version from the downloaded tarball. With this change pacakge that has name "-tests-" will be ignored. No ROCm download progress print in github action and print success.
Fixing the issue of the skipped workflow being triggered
With ROCm 7.15 nightly additional packages are present and causing issue with the ROCm tarball fetching logic. Issue was due to grep -v causing the index to be be emptied out and not able to find the right tarball.
Report test result correctly.
* mi350p config cherrypick * remove iet single * Documentation - Additions, Corrections and Updates. (#1150) * Additions, Corrections and Updates in docs * update _toc.yml.in to display updated files on web * update index --------- Co-authored-by: Peter Park <peter.park@amd.com> (cherry picked from commit 7417426) * docs: Update installation page for 7.13 (#1151) * docs(rvs): move installation.rst to build.rst * docs(rvs): add install page add link to compat * docs: update heading in `build.rst` * remove stale doc * fix yaml indentation breaking sphinx build (cherry picked from commit 555be6e) * docs: fix rocm core sdk docs url * Fix broken links in header & footer (#1178) * Fix broken link in header * fix per review * Update links and copyright info * update per review * Remove production releases from the list (#1189) * Update version slug * tighten wording * bump rocm-docs-core to 1.35.0 * hardcode interSphinx link (#1207) * Install RVS using native packages * update RVS versions * one more * add patch version * clarify install methods * add 1.5.122 rvs install doc * update RVS versions to 1.5.122 * add back transfer bench doc * update 7.14 install url * add notes --------- Co-authored-by: Davood Saffar <dsaffars@amd.com> Co-authored-by: Manoj S K <manoj.sk@amd.com> Co-authored-by: Mohammed Junaid <88209527+jkottiku@users.noreply.github.com> Co-authored-by: Peter Park <peter.park@amd.com> Co-authored-by: Alex Xu <alex.xu@amd.com>
* mi350p config cherrypick * remove iet single * Documentation - Additions, Corrections and Updates. (#1150) * Additions, Corrections and Updates in docs * update _toc.yml.in to display updated files on web * update index --------- Co-authored-by: Peter Park <peter.park@amd.com> (cherry picked from commit 7417426) * docs: Update installation page for 7.13 (#1151) * docs(rvs): move installation.rst to build.rst * docs(rvs): add install page add link to compat * docs: update heading in `build.rst` * remove stale doc * fix yaml indentation breaking sphinx build (cherry picked from commit 555be6e) * docs: fix rocm core sdk docs url * Fix broken links in header & footer (#1178) * Fix broken link in header * fix per review * Update links and copyright info * update per review * Remove production releases from the list (#1189) * Update version slug * tighten wording * bump rocm-docs-core to 1.35.0 * hardcode interSphinx link (#1207) * Install RVS using native packages * update RVS versions * one more * add patch version * clarify install methods * add 1.5.122 rvs install doc * update RVS versions to 1.5.122 * add back transfer bench doc * update 7.14 install url * add notes * Update RVS install doc * add notes about transferbench * update lastest version * Revert "Merge branch 'master' into docs/1.5.122" This reverts commit dcd06c6, reversing changes made to 7720ab7. * use OS tabs * minor edits * update verification command * use external doc link --------- Co-authored-by: Davood Saffar <dsaffars@amd.com> Co-authored-by: Manoj S K <manoj.sk@amd.com> Co-authored-by: Mohammed Junaid <88209527+jkottiku@users.noreply.github.com> Co-authored-by: Peter Park <peter.park@amd.com> Co-authored-by: Alex Xu <alex.xu@amd.com>
This is to cleanup the workspace after build is done.This helps to reclaim disk space while running parallel jobs.
Make libpci static and cleanup.
Reformatting Babel json logging
Sync-up with master
Co-authored-by: yugang-amd <yugang.wang@amd.com>
User-guide update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist