[rmsnorm] Support FP32 weights with FP16/BF16 activations#884
Open
jhinpan wants to merge 1 commit into
Open
Conversation
zhiding512
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the mixed-weight training contract used by Quack: FP16/BF16 activations with FP32 RMSNorm weights, while preserving all existing same-dtype paths.
out/dxin activation dtype anddweightin the original weight dtype.rmsnorm_direct(..., dtype_str, BLOCK_THREADS, stream)API.Verification
28 passed.5 passed.2 passed.13 passed.py_compile, andgit diff --check: passed.Runtime correctness and benchmark coverage on gfx942 will run in the existing MI325 PR jobs.
Refs #749 and Dao-AILab/quack#178.