Skip to content

Dont use double or int64 when using fast_math#4641

Open
pfultz2 wants to merge 2 commits intodevelopfrom
gpu-64bit-type
Open

Dont use double or int64 when using fast_math#4641
pfultz2 wants to merge 2 commits intodevelopfrom
gpu-64bit-type

Conversation

@pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Feb 27, 2026

Motivation

Double precision and 64bit math is very slow on the GPU so dont use it when fast_math is enabled.

Technical Details

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

@pfultz2 pfultz2 requested a review from causten as a code owner February 27, 2026 17:38
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4641   +/-   ##
========================================
  Coverage    92.23%   92.23%           
========================================
  Files          567      567           
  Lines        27953    27953           
========================================
+ Hits         25781    25782    +1     
+ Misses        2172     2171    -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant