Skip to content

[Quality][Medium] Enforce protocol-limit configuration invariants #2413

Description

@Baskarayelu

Objective

Validate configuration relationships at initialization and update time, with explicit errors for unsafe combinations.

Why this matters

Independent limits such as maximum invoices, bid windows, and transfer sizes can form contradictory configurations that only fail at runtime.

This is a substantive production-quality improvement. It must change runtime behavior, security guarantees, correctness, reliability, or meaningful user functionality. It is not a documentation-only, formatting-only, or trivial dependency task.

Scope

Area: configuration and boundary validation

Starting points: src/init.rs, src/admin.rs, src/types.rs, docs/QLX_INVOICE_LOCK_TIME_LIMITS.md

The contributor should verify the current implementation before changing it and keep the PR limited to this issue. Do not introduce unrelated refactors or weaken existing CI/security gates.

Acceptance criteria

  • All configured limits have checked numeric bounds.
  • Dependent limits cannot create impossible or unbounded lifecycle windows.
  • Invalid configuration updates are atomic and leave the previous configuration active.
  • Effective limits are exposed through a read-only diagnostic path.

Required validation

  • Test minimum, maximum, zero, overflow, and contradictory configurations.

  • Test updates while invoices are active.

  • Add a configuration round-trip and event test.

  • The PR explains the failure mode, the chosen design, backward-compatibility impact, and rollback or migration considerations.

  • The PR includes CI evidence and does not contain secrets, generated noise, unrelated cleanup, or disabled checks.

Contributor deliverables

  • Open a focused feature branch and do not begin implementation until assigned.
  • Reference this issue with Closes #<issue-number> or Fixes #<issue-number>.
  • Check off every acceptance criterion in the PR with links to the relevant code and tests.
  • Include a security/correctness note explaining why adversarial inputs cannot bypass the new guarantee.

Maintainer quality bar

The PR must be independently reviewable, preserve existing behavior outside this scope, exercise failure paths, and pass the repository's complete required CI/CD checks. Reward eligibility is not guaranteed by this issue or by merging.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions