Skip to content

Mark more error strings lazy#478

Merged
lkdvos merged 1 commit into
mainfrom
ksh/lazy_errors
Jul 9, 2026
Merged

Mark more error strings lazy#478
lkdvos merged 1 commit into
mainfrom
ksh/lazy_errors

Conversation

@kshyatt

@kshyatt kshyatt commented Jul 9, 2026

Copy link
Copy Markdown
Member

Makes JET happier

@kshyatt kshyatt requested a review from lkdvos July 9, 2026 16:09

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the debug messages, is this necessary to make JET happy? It does not necessarily make that much sense there since that is anyways only evaluated if the debug messages are enabled, in which case we have to instantiate that string anyways

@kshyatt

kshyatt commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

Yes, Jet was complaining about them. I agree it's goofy.

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/tensors/treetransformers.jl 25.00% 3 Missing ⚠️
src/spaces/homspace.jl 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/tensors/vectorinterface.jl 86.36% <100.00%> (ø)
src/spaces/homspace.jl 91.36% <33.33%> (-1.34%) ⬇️
src/tensors/treetransformers.jl 82.69% <25.00%> (-2.46%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos merged commit cfaa073 into main Jul 9, 2026
78 of 79 checks passed
@lkdvos lkdvos deleted the ksh/lazy_errors branch July 9, 2026 22:13
@lkdvos lkdvos mentioned this pull request Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants