Skip to content

fix(#539): finish the CookieSyncManager removal by calling CookieManager.flush() #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jim-daf wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Draft

fix(#539): finish the CookieSyncManager removal by calling CookieManager.flush() #1350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/quantumbadger/redreader/fragments/WebViewFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,8 +523,11 @@ public void onDestroyView() {
outer.removeAllViews();
webView.destroy();

// CookieSyncManager was removed in favour of CookieManager flush()
// for API 21 plus, see https://developer.android.com/reference/android/webkit/CookieManager#flush()
final CookieManager cookieManager = CookieManager.getInstance();
cookieManager.removeAllCookies(null);
cookieManager.flush();

super.onDestroyView();
}
Expand Down
Loading