Skip to content

CompatHelper: bump compat for CUDA in [weakdeps] to 6, (keep existing compat) - #587

Open
github-actions[bot] wants to merge 1 commit into
masterfrom
compathelper/new_version/2026-05-23-01-05-51-705-02191510745
Open

CompatHelper: bump compat for CUDA in [weakdeps] to 6, (keep existing compat)#587
github-actions[bot] wants to merge 1 commit into
masterfrom
compathelper/new_version/2026-05-23-01-05-51-705-02191510745

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This pull request changes the compat entry for the CUDA package from 4, 5 to 4, 5, 6.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@Roger-luo
Roger-luo force-pushed the compathelper/new_version/2026-05-23-01-05-51-705-02191510745 branch from b677fc1 to 935bdd4 Compare May 23, 2026 01:05
@codecov

codecov Bot commented May 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (8f17bfb) to head (935bdd4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   89.22%   89.22%           
=======================================
  Files          89       89           
  Lines        5855     5855           
=======================================
  Hits         5224     5224           
  Misses        631      631           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GiggleLiu

Copy link
Copy Markdown
Member

Current registry/release evidence supports considering CUDA 6.3.1: CUDA 6.0 describes the package split as the reason for the cautious major bump and says no intentional breaking API changes. This PR’s exact head 935bdd462187d0cde9a8bd6ab4dbbf064228388a only widens the root weak-dependency compat, however; ext/CuYao/test/Project.toml still restricts CUDA to 4, 5, and the passing CPU CI jobs do not exercise the CUDA extension on a GPU. I am leaving it open rather than treating those checks as CUDA 6 validation. A qualifying update should widen the test environment to 6 and run the CuYao extension suite on CUDA 6 (or document equivalent GPU CI evidence).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant