Skip to content

fix: support guppylang internals API changes#3

Merged
qartik merged 1 commit into
mainfrom
codex-guppylang-compat
Jun 25, 2026
Merged

fix: support guppylang internals API changes#3
qartik merged 1 commit into
mainfrom
codex-guppylang-compat

Conversation

@qartik

@qartik qartik commented Jun 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Add compatibility shims for guppylang-internals API changes around type member registration and CustomFunctionDef.
  • Widen dependency metadata to support the stable guppylang 0.21.x line while excluding the 1.0.0a* prerelease API line.
  • Refresh uv.lock with the updated dependency constraints.

Root Cause

Newer guppylang-internals versions renamed DEF_STORE.register_impl(...) to DEF_STORE.register_type_member(...). The CustomFunctionDef constructor also differs across the supported guppylang-internals versions, so direct construction needed to account for both signatures.

Validation

  • uv run pytest -q
  • uvx ruff check src/guppy_gpu/decorator.py
  • Stable compatibility matrix for non-yanked guppylang versions from 0.21.4 through 0.21.16
  • Clean install matrix for non-yanked guppylang versions from 0.21.4 through 0.21.16

@qartik qartik requested a review from Copilot June 25, 2026 11:47
@qartik qartik marked this pull request as ready for review June 25, 2026 11:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates guppy-gpu to remain compatible across a wider range of guppylang-internals / guppylang versions by introducing small compatibility shims for renamed APIs and constructor signature changes, and by adjusting dependency constraints accordingly.

Changes:

  • Add a DEF_STORE.register_type_member/register_impl compatibility shim and route type-member registration through it.
  • Add a CustomFunctionDef construction shim to tolerate constructor signature differences across supported versions.
  • Update pyproject.toml dependency bounds (and bump package version to 0.1.2) to support the 0.21.x stable line while excluding 1.0.0a* prereleases.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/guppy_gpu/decorator.py Adds shims for DEF_STORE member registration and CustomFunctionDef creation; updates call sites to use them.
pyproject.toml Bumps package version and adjusts dependency constraints/upper bounds to match the targeted compatibility range.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/guppy_gpu/decorator.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Comment thread pyproject.toml
Comment thread src/guppy_gpu/decorator.py

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

@qartik qartik merged commit ea2ccb1 into main Jun 25, 2026
1 check passed
@qartik qartik deleted the codex-guppylang-compat branch June 25, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants