fix: support guppylang internals API changes#3
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates guppy-gpu to remain compatible across a wider range of guppylang-internals / guppylang versions by introducing small compatibility shims for renamed APIs and constructor signature changes, and by adjusting dependency constraints accordingly.
Changes:
- Add a
DEF_STORE.register_type_member/register_implcompatibility shim and route type-member registration through it. - Add a
CustomFunctionDefconstruction shim to tolerate constructor signature differences across supported versions. - Update
pyproject.tomldependency bounds (and bump package version to0.1.2) to support the0.21.xstable line while excluding1.0.0a*prereleases.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/guppy_gpu/decorator.py |
Adds shims for DEF_STORE member registration and CustomFunctionDef creation; updates call sites to use them. |
pyproject.toml |
Bumps package version and adjusts dependency constraints/upper bounds to match the targeted compatibility range. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8add507 to
1060484
Compare
1060484 to
9fee6b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guppylang-internalsAPI changes around type member registration andCustomFunctionDef.guppylang0.21.xline while excluding the1.0.0a*prerelease API line.uv.lockwith the updated dependency constraints.Root Cause
Newer
guppylang-internalsversions renamedDEF_STORE.register_impl(...)toDEF_STORE.register_type_member(...). TheCustomFunctionDefconstructor also differs across the supportedguppylang-internalsversions, so direct construction needed to account for both signatures.Validation
uv run pytest -quvx ruff check src/guppy_gpu/decorator.pyguppylangversions from0.21.4through0.21.16guppylangversions from0.21.4through0.21.16