Repository navigation
Run full wasm test suite in JupyterLite terminal as well as cockle - #197
Open
ianthomas23 wants to merge 1 commit into
Open
ianthomas23 wants to merge 1 commit into
ianthomas23 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 88.34% 86.78% -1.57%
==========================================
Files 64 64
Lines 3072 3072
Branches 376 375 -1
==========================================
- Hits 2714 2666 -48
- Misses 358 406 +48 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This runs the full test suite in the JupyterLite terminal as well as cockle. Primarily this tests that the JupyterLite shared drive (in the
/drivedirectory) behaves correctly for all of ourgit2cppworkflows.The two run as separate jobs in the test-wasm CI run, after the build stage. The README is updated to explain the usage, we now have separate
make test-cockleandmake test-litecommands. The approach fortest-liteis similar to that oftest-cockleexcept that we do not have direct JavaScript access to thecockleShell, instead we have a terminal within the JupyterLite UI that we can enter keystrokes in, and files written are accessible from the JupyterLite contents manager.test-liteis slower to run thantest-cockle.There are two tests that are skipped on
test-liteas they use symlinks which are not supported by the JupyterLite shared drive. We also have a new test added in this PR calledtest_checkout_rmdir_bugwhich fails when run onjupyterlite <= 0.8.6but will be fixed in the next release due out next week hopefully.Closes #195.