Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 22, 2025

Bumps sympy from 1.13.3 to 1.14.0.

Commits
  • 16fa855 Merge pull request #28004 from oscarbenjamin/pr_bump_version_114
  • 597028e release: bump version to 1.14.0 final
  • db82759 Merge pull request #27996 from oscarbenjamin/pr_27994_114_backport
  • 9861163 release: bump version to 1.14.0rc2
  • d114acf Revert passing init_printing settings to the pretty printer
  • 7f50681 Merge pull request #27970 from oscarbenjamin/pr_benchmarks_114
  • 1721b69 maint(ci): fix paths in action
  • fa12f64 maint(ci): fix benchmarks on 1.14 branch
  • 2b73e0c Merge pull request #27960 from oscarbenjamin/pr_pin_mpmath
  • a66be8c maint(ci): use Python 3.12 for flint==0.6.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [sympy](https://github.com/sympy/sympy) from 1.13.3 to 1.14.0.
- [Release notes](https://github.com/sympy/sympy/releases)
- [Commits](sympy/sympy@sympy-1.13.3...sympy-1.14.0)

---
updated-dependencies:
- dependency-name: sympy
  dependency-version: 1.14.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added conda Pull requests that update conda code dependencies Pull requests that update a dependency file labels Dec 22, 2025
@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 815722c
🔍 Latest deploy log https://app.netlify.com/projects/taupe-gaufre-c4e660/deploys/694a20a2838b490008ce6e0d
😎 Deploy Preview https://deploy-preview-683--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

@github-actions github-actions bot temporarily deployed to pull request December 23, 2025 02:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 23, 2025 02:34 Inactive
@mmcky mmcky requested a review from Copilot December 23, 2025 03:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the sympy dependency from version 1.13.3 to 1.14.0 as part of routine dependency maintenance. However, there's a documentation inconsistency that needs to be addressed.

  • Updates sympy version constraint from 1.13.3 to 1.14.0
  • Outdated comments reference a bug in 1.14.0 that justified the previous pin

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

environment.yml Outdated
Comment on lines 18 to 19
# TODO: Check for SymPy 1.14.1+ when available
# Pinned to 1.13.3 due to bug in 1.14.0 causing OverflowError in solve()
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments on lines 18-20 indicate that sympy was pinned to 1.13.3 due to a bug in 1.14.0, but this PR is updating to version 1.14.0. These comments should be removed or updated since they no longer accurately reflect the version being used. Keeping outdated comments can confuse future maintainers about why certain version choices were made.

Suggested change
# TODO: Check for SymPy 1.14.1+ when available
# Pinned to 1.13.3 due to bug in 1.14.0 causing OverflowError in solve()
# TODO: When SymPy 1.14.1+ is available and verified, consider updating this pin
# Previously pinned to 1.13.3 due to bug in 1.14.0 causing OverflowError in solve()

Copilot uses AI. Check for mistakes.
@mmcky
Copy link
Contributor

mmcky commented Dec 23, 2025

Verified that SymPy 1.14.0 works correctly with the solow.md lecture. The bug that caused OverflowError in solve() for symbolic differentiation has been fixed.

Testing performed:

  • Full local execution of solow.md notebook with SymPy 1.14.0 ✅
  • The solve(c.diff()) call now returns s_star = 0.300000000000000 correctly

Changes made:

  • Removed the explicit sympy pin entirely since sympy is already included in the anaconda distribution (anaconda=2025.12)
  • Removed the outdated TODO comments referencing the 1.14.0 bug

Note: The CI passed but was using cached execution results from main branch. Local testing confirmed the fix.

@github-actions github-actions bot temporarily deployed to pull request December 23, 2025 05:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 23, 2025 05:03 Inactive
@mmcky mmcky merged commit c79d1da into main Dec 23, 2025
7 checks passed
@mmcky mmcky deleted the dependabot/conda/sympy-1.14.0 branch December 23, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda Pull requests that update conda code dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants