Fix encoding error happen when running in CJK windows. - #24
Merged
Conversation
Qonfused
added
status:done
Qonfused
added a commit
that referenced
this pull request
Jul 27, 2026
Remove incorrect encoding parameter from binary mode open() call.
Binary mode ('rb') doesn't accept encoding parameter.
This was incorrectly added in PR #24 (CJK encoding fix) which added
encoding to all open() calls, but binary mode doesn't accept encoding.
Fixes: ValueError: binary mode doesn't take an encoding argument
when running lock --update on projects with local file paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve Issue #23
When open or write file by any type, make it force to open or write by utf-8 encoding