Remove widget from client (DO NOT MERGE - NEED DEPRECATION FIRST)#2229
Open
ItamarGoldman wants to merge 4 commits into
Open
Remove widget from client (DO NOT MERGE - NEED DEPRECATION FIRST)#2229ItamarGoldman wants to merge 4 commits into
ItamarGoldman wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of the work in refactoring the client, removing the widget from the client.
Implementation Checklist
client/qiskit_serverless/visualization/directorywidget()method fromBaseClientipywidgetsdependency can be removed from requirementsDetails and comments
Files to Remove
1. Widget Module Files
client/qiskit_serverless/visualization/widget.py- Main widget implementationclient/qiskit_serverless/visualization/__init__.py- Module initializationclient/qiskit_serverless/visualization/- Entire directory can be removedFiles to Update
1. BaseClient Class
File:
client/qiskit_serverless/core/client.py:191-198Action: Delete lines 187-198 (entire widget section)
Impact Assessment
✅ No Impact Areas
Main Package API -
client/qiskit_serverless/__init__.pyDocumentation -
docs/.rstfiles mention widget or visualizationTests -
client/tests/Dependencies
ipywidgetsbut this is likely already a dependencyrequirements.txtorsetup.pyto see ifipywidgetscan be removed