Upload program refactor#1743
Draft
korgan00 wants to merge 16 commits into
Draft
Conversation
Contributor
Author
|
Should we allow spaces in function names? |
Collaborator
|
I don't think there is any added value in allowing spaces in function names, on my side I wouldn't allow it. |
korgan00
force-pushed
the
upload-program-refactor
branch
from
7fb9c5b to
ea25f6a
Compare
…load-program-refactor
Contributor
Member
|
I let @korgan00 decide here, do you think we can reuse this PR to continue with this refactor or is it better and start from scratch? |
Contributor
Author
|
I have to revisit it, but i think it will probably be reusable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments