This repository was archived by the owner on Sep 30, 2026. It is now read-only.
Repository navigation
feat(workspace): follow imports configured in qbxlint.toml - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Language server support for
importsinqbxlint.toml(Qbox-project/qbx-lua#6), which lists files resources run without anfxmanifest.luaentry.resource_importsandResourceEnv::add_import, so the editor reports the same globals as the CLI.qbxlint.tomlchanges and when a new Lua file appears, since it may match a glob.importsnames is indexed on the nextqbx/reindexor restart, like manifest dependencies.docs/protocol.mddescribes when import changes apply.Depends on Qbox-project/qbx-lua#6. CI builds against qbx-lint's
main, so this PR will not compile there until that PR is merged.Checks
cargo fmt --check,cargo clippy --all-targets(no warnings) andcargo testpass on Windows, built against the qbx-lint branch checked out next to this repo. Not run on Linux locally.tests/workspace_refresh.rscovering globals by side, a resource the override does not cover, definitions reaching the imported file, and the imports going away when the config is removed.Generated with Claude Code