Repository navigation
chore: use the combined Lua tooling workspace - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use the combined
qbx-lintCargo workspace for editor development, CI, bundled-server release builds, resource fixtures, and Zed downloads. The separate language-server checkout is no longer required; the executable and archive names remainqbx-lua-ls.Uses the workspace migration merged in Qbox-project/qbx-lua#8 and updates all editor/Zed manifests to
1.0.5for the first shared release. Old linter tags do not contain the server crate or server release assets. The contribution guide and editor setup instructions document the new checkout paths and cutover order.The first shared tooling release must be available before merging and publishing this editor release so Zed can download the server from its new location.
Checks
npm run typecheck,npm run build, and the full VS Code integration suite passed on Windows with the server built from the combined workspace.python -m unittest discover -s scripts -p 'test_*.py': all seven Marketplace verification tests passed.wasm32-wasip2, and the Wasm release build passed.npm run package -- --target win32-x64: the VSIX packaged successfully, contains the exact new workspace server binary, and installed successfully into an isolated VS Code test profile.No Marketplace release was published during validation. Linux/macOS packaging and interactive Zed testing were not performed locally.