refactor(voice): Strict type checking in voice internals & DAVE Support (rec)#3159
Draft
Paillat-dev wants to merge 7 commits intomasterfrom
Draft
refactor(voice): Strict type checking in voice internals & DAVE Support (rec)#3159Paillat-dev wants to merge 7 commits intomasterfrom
Paillat-dev wants to merge 7 commits intomasterfrom
Conversation
Discord enforces DAVE (E2E encryption) on all voice channels. py-cord currently decodes Opus packets before stripping the DAVE application-layer encryption, causing OpusError: corrupted stream and making voice reception completely non-functional. Changes: - reader.py: Rewrite decrypt_rtp() to call dave.decrypt() BEFORE Opus decoding. Handles SSRC-to-user_id race condition by trying all known DAVE user IDs when the mapping is not yet populated, then caching the result. Falls back to OPUS_SILENCE on decrypt failure. - opus.py: Remove erroneous dave.decrypt() call in _decode_packet() that was applied to already-decoded PCM data, corrupting the audio stream. - router.py: Catch OpusError and AssertionError in _do_run() gracefully, emitting a single warning instead of crashing the router thread. Fixes: #3139
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3159/head:pr-3159
git checkout pr-3159This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3159/head |
Paillat-dev
commented
Mar 19, 2026
This was
linked to
issues
Mar 19, 2026
Open
Paillat-dev
force-pushed
the
fix/voice-rec-2
branch
from
3890460 to
fee38b7
Compare
Paillat-dev
commented
Mar 20, 2026
|
|
||
| data.seek(0) | ||
| output = BytesIO() | ||
| with wave.open(output, "wb") as f: |
Member
Author
There was a problem hiding this comment.
See if similar is required by other sinks or if it's even needed here idk if we might actually be better of undoing this. Test the other sinks
Paillat-dev
commented
Mar 20, 2026
| if uid: | ||
|
|
||
| if not uid: | ||
| # SSRC -> user_id mapping not yet populated (race with member_connect). |
Member
Author
There was a problem hiding this comment.
"Bruteforcing" like this is ugly and hacky. See if we can have polling & timeout instead or similar.
Paillat-dev
commented
Mar 20, 2026
| finally: | ||
| self.reader.client.stop_recording() | ||
| try: | ||
| self.reader.client.stop_recording() |
11 tasks
Lulalaby
added
help wanted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.