refactor: Update ``Client.run`` to have a better async I/O usage by DA-344 · Pull Request #2645 · Pycord-Development/pycord

DA-344 · 2024-11-11T19:42:52Z

Summary

This PR refactors the Client.run logic to fix problems involving asyncio due to how the library used the loop:

Needs testing

Exception

  File "/home/container/main.py", line 23, in <module>
    bot.run(BOT_TOKEN)

  File "/home/container/.local/lib/python3.11/site-packages/discord/client.py", line 772, in run
    loop.run_forever()

  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 608, in run_forever
    self._run_once()

  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 1936, in _run_once
    handle._run()

  File "/usr/local/lib/python3.11/asyncio/events.py", line 84, in _run
    self._context.run(self._callback, *self._args)

  File "/usr/local/lib/python3.11/asyncio/selector_events.py", line 956, in _read_ready
    self._read_ready_cb()

  File "/usr/local/lib/python3.11/asyncio/selector_events.py", line 988, in _read_ready__get_buffer
    self._protocol.buffer_updated(nbytes)

  File "/usr/local/lib/python3.11/asyncio/sslproto.py", line 439, in buffer_updated
    self._do_handshake()

  File "/usr/local/lib/python3.11/asyncio/sslproto.py", line 560, in _do_handshake
    self._sslobj.do_handshake()

  File "/usr/local/lib/python3.11/ssl.py", line 979, in do_handshake
    self._sslobj.do_handshake()

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

discord/client.py

Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>

DA-344 · 2024-11-19T15:17:38Z

Applied all the changes Dorukyum requested.

Before merging, I would like some feedback on this discussion message

Paillat-dev · 2026-02-07T16:14:16Z

@Lumabots When able can you run this for like 24h with some bot ?

Paillat-dev · 2026-02-12T14:23:56Z

CHANGELOG.md

  ([#2905](https://github.com/Pycord-Development/pycord/pull/2905))
 - `view=None` in various methods causing an AttributeError.
  ([#2915](https://github.com/Pycord-Development/pycord/pull/2915))
+- Fixed Async I/O errors that could be raised when using `Client.run`.


This probably should be more extensive.

Paillat-dev · 2026-02-12T14:24:45Z

discord/ext/tasks/__init__.py

 )


+def is_ambiguous(dt: datetime.datetime) -> bool:


Not sure what this is doing here. Is it required ? Or is it an additional feature ? In any case it should at least be in the changelog and maybe a separate PR depending on what the others think

it is used internally on Loop.

Yeah, but it wasn't present before. Does it change / increase the types of accepted inputs for loops ?

this checks whether a datetime object falls in a ambiguous local time by DST transition (eg Spanish winter & summer local times)

so there is a moment in which the clock is set back and the same local hour occurs twice (that is why it uses fold)

this checks whether the datetime already has timezone data (dt.tzinfo) or uses a utc or fixed-offset datetime.timezone instance.

Please remove the unrelated datetime changes and (if you want) move them to a separate pull request, I feel like this PR is already heavy enough

plun1331

This looks like it refactors a large amount of ext.tasks, much of it unrelated to asyncio usage. That should be in a different pull request.

plun1331 · 2026-02-13T20:35:56Z

discord/ext/tasks/__init__.py

+    loop: asyncio.AbstractEventLoop | None = None,
+    name: str | None = MISSING,
    overlap: bool | int = False,
+    create_loop: bool = False,


Technically makes this breaking I believe. True default probably wouldn't be most ideal though?

it wouldn't be breaking as long as Client.start is called.

So it is breaking

plun1331 · 2026-02-13T20:38:08Z

discord/client.py

        return task

    def dispatch(self, event: str, *args: Any, **kwargs: Any) -> None:
-        _log.debug("Dispatching event %s", event)


plun1331 · 2026-02-13T20:41:35Z

discord/state.py

        **options: Any,
    ) -> None:
-        self.loop: asyncio.AbstractEventLoop = loop
+        self.loop: asyncio.AbstractEventLoop = loop or MISSING


Is there a difference between using None and MISSING here?

there is no difference here tbh, but it is done to prevent assert state.loop is not None everytime state.loop is accessed.

Paillat-dev · 2026-03-08T14:15:59Z

Could you take a look at #2873 (comment) ?

…o fix/client-run

Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>

DA-344 added 3 commits November 11, 2024 18:25

fix: client.run not allowing bots to start

de49cf5

chore: Update more things

4fe559f

chore: Move the loop update to .start

74863c5

DA-344 requested a review from a team as a code owner November 11, 2024 19:42

pullapprove4 bot requested a review from ChickenDevs November 11, 2024 19:42

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Nov 11, 2024

DA-344 and others added 7 commits November 11, 2024 21:31

chore: Added logging and updated run to specify the arguments

72f904c

style(pre-commit): auto fixes from pre-commit.com hooks

7e7f1e9

chore: Updated CHANGELOG

f289f74

Merge changes from remote

2195dc6

style(pre-commit): auto fixes from pre-commit.com hooks

3d235ee

dot

07ccbc9

Merge branch 'master' into fix/client-run

ef835dc

Lulalaby requested review from Dorukyum, NeloBlivion and plun1331 and removed request for ChickenDevs November 11, 2024 23:03

Dorukyum requested changes Nov 18, 2024

View reviewed changes

discord/client.py Outdated Show resolved Hide resolved

discord/client.py Outdated Show resolved Hide resolved

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Nov 18, 2024

DA-344 and others added 2 commits November 19, 2024 08:23

Update docstrings

5e8a322

Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>

Update docstrings

de5156c

Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>

DA-344 added 6 commits November 19, 2024 16:25

merge 'master' from https://github.com/Pycord-Development/pycord

b830a94

chore: Update Client.__aenter__ and Client.run

88484e2

feat: Add operations container to Client docstring

ba81ebe

chore: merge branch 'master' from Pycord-Development/pycord

f5f0085

chore: Update Client.close to prevent double closing and race conditions

28fab35

fix: Indentation error

c378d41

Lulalaby force-pushed the master branch from cb403d2 to 7bb2a2d Compare December 24, 2025 15:42

Lulalaby added this to the v2.8 milestone Dec 24, 2025

Lulalaby removed the on hold label Dec 24, 2025

Paillat-dev added priority: high High Priority and removed priority: medium Medium Priority labels Dec 26, 2025

Paillat-dev and others added 4 commits December 26, 2025 14:19

Merge branch 'master' into fix/client-run

c653e3b

Merge branch 'master' into fix/client-run

a24086a

Merge branch 'master' into fix/client-run

a44d4a5

Merge branch 'master' into fix/client-run

f15ae53

Paillat-dev reviewed Feb 12, 2026

View reviewed changes

plun1331 requested changes Feb 13, 2026

View reviewed changes

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Feb 13, 2026

Merge branch 'master' into fix/client-run

4fbc3b9

Paillat-dev mentioned this pull request Mar 8, 2026

refactor(voice): Rewrite Voice Internals & DAVE Support (send & receive) #2873

Closed

9 tasks

DA-344 and others added 6 commits March 12, 2026 16:00

revert ext.tasks changes

d0142fe

Merge branch 'fix/client-run' of https://github.com/DA-344/pycord int…

73b0eeb

…o fix/client-run

re-add log

20dfac7

use contextlib.suppress

494f81c

Merge branch 'master' into fix/client-run

6907553

Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

78ae37a

Paillat-dev modified the milestones: v2.8.0rc.1, next-major Mar 15, 2026

Lulalaby added this to Pycord Mar 18, 2026

github-project-automation bot moved this to Todo in Pycord Mar 18, 2026

Merge branch 'master' into fix/client-run

c74a1f0

Paillat-dev self-requested a review March 21, 2026 21:26

Uh oh!

Conversation

DA-344 commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

Uh oh!

Uh oh!

DA-344 commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Paillat-dev commented Feb 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DA-344 Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

plun1331 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Paillat-dev commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

DA-344 commented Nov 11, 2024 •

edited

Loading

DA-344 commented Nov 19, 2024 •

edited

Loading

DA-344 Feb 12, 2026 •

edited

Loading