Insert produces unwanted whitespaces and insert handles index weirdly#55
Merged
Psycojoker merged 7 commits intomasterfrom Feb 2, 2015
Merged
Insert produces unwanted whitespaces and insert handles index weirdly#55Psycojoker merged 7 commits intomasterfrom
Psycojoker merged 7 commits intomasterfrom
Conversation
added 2 commits
January 30, 2015 03:45
Furthermore, this shows an unexpected behaviour with the index in a LineProxyList. The .insert(2, ...) should insert just before "class B" but instead inserts after it. This is because the \n after "class A" is merged with that node's value but it shouldn't.
Psycojoker
force-pushed
the
insert_whitespace
branch
from
092b13d to
30d1436
Compare
Member
|
I've fixed the whitespace stuff (at least, in a pragmatic way, forcing the diffing algorithm the handle pep8 correctly is way more work). I'm not sure how to handle the bounding box stuff, I think that we might need to talk about it :/ |
Collaborator
Author
Psycojoker
added a commit
that referenced
this pull request
Feb 2, 2015
Insert produces unwanted whitespaces and insert handles index weirdly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first two commits of this PR shows a problem and something weird with the index that insert accepts.
The problem is that inserting a line adds newlines. Looks like issue #48.
The weird thing is that it seems impossible to add a line just after a class (see first commit for that) and it seems to come from the fact that the \n after the class is still part of that class' .value (see second commit for confirmation).
It's the same thing with a "def" node.