Return converted times from convert_time instead of printing#66
Merged
bbelderbos merged 3 commits intoPyBites-Open-Source:mainfrom Feb 9, 2026
Merged
Return converted times from convert_time instead of printing#66bbelderbos merged 3 commits intoPyBites-Open-Source:mainfrom
bbelderbos merged 3 commits intoPyBites-Open-Source:mainfrom
Conversation
Refactor WorldClock to collect results in a list and print them after conversion.
for more information, see https://pre-commit.ci
Change return type from None to list of tuples.
Laksh0p
commented
Feb 5, 2026
Contributor
Author
Laksh0p
left a comment
Laksh0p
left a comment
There was a problem hiding this comment.
Fix return type hint for convert_time
Collaborator
|
Nice, thanks. |
Collaborator
|
Thanks again for picking this up. Do you have time to look at the testing a bit as well please? I got a notification CI/CD pipeline fails atm: Thanks, |
Contributor
Author
|
Hi Bob,
Thanks for flagging this.
Sorry for replying this late I was busy with something, but I’ll take a
look at the failing tests on 11th *after 6 PM(indian standard time) *and follow
up with an update( I have an exam today TwT).
Thanks for your patience.
Best,
Laksh
…On Mon, Feb 9, 2026, 6:00 PM Bob Belderbos ***@***.***> wrote:
*bbelderbos* left a comment (PyBites-Open-Source/pybites-tools#66)
<#66 (comment)>
Thanks again for picking this up. Do you have time to look at the testing
a bit as well please?
I got a notification CI/CD pipeline fails atm:
https://github.com/PyBites-Open-Source/pybites-tools/actions/runs/21824345734/job/62965283259
Thanks,
Bob
—
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BVFZXQSEHBEXVVPDSZHFWP34LB4VBAVCNFSM6AAAAACUCO3KTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNZRGQZTEOBSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
No rush at all on this, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
convert_timeto return a list of(timezone, formatted_time)tuples instead of printing directly.
The printing logic has been moved to the CLI (
main) soconvert_timecan be reused from other modules, as discussed.
Fixes #43