Event Schema Freeze (Indexers-Friendly) - #567#689
Open
Aj-Kayvee wants to merge 1 commit into
Open
Conversation
- Rename ExtendedEvent.id → package_id for indexer consistency - Add comprehensive on-chain event tests for BatchCreated, SurplusWithdrawn, ContractPaused/Unpaused, ActionPaused/Unpaused events - Add test_all_package_events_include_package_id to validate all package events carry the package_id field - Add backend claim.events.spec.ts to validate ClaimCancelledEvent and ClaimReissuedEvent payload shapes - Add claim_id to AI service evidence upload and artifact access events - Add artifact_id to artifact_access_denied error events - Remove orphaned snapshot files from removed tests - Update contract README with complete event schema documentation Closes Pulsefy#567
|
@Aj-Kayvee is attempting to deploy a commit to the Cedarich's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Aj-Kayvee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Aj-Kayvee please fix workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes event topics and payload shapes so indexers and backend correlation remain stable across releases. Closes #567.
Changes
On-Chain Contract (Rust)
ExtendedEvent.id→package_id: Renamed for indexer consistency so all package-scoped events use the same field nametests/events.rs:test_batch_created_event— validatesids,admin,total_amounttest_surplus_withdrawn_event— validatesto,token,amounttest_contract_paused_event/test_contract_unpaused_eventtest_action_paused_event/test_action_unpaused_eventtest_all_package_events_include_package_id— verifies every package lifecycle event carriespackage_idin its payloadBackend (NestJS/TypeScript)
claim.events.spec.ts— new test suite validating:ClaimCancelledEventandClaimReissuedEventrequired fields and typesreasonfield correctly omittedAI Service (Python/FastAPI)
claim_idfield via optionalX-Claim-Idheader toevidence_upload_session_createdandevidence_upload_finalizedclaim_idfrom artifact metadata toartifact_access_grantedandartifact_downloaded_with_signed_url; addedartifact_idtoartifact_access_deniederror logsVerification
cargo testclaim_idwhere available