Missing guard#631
Open
innovativedesign-lab wants to merge 8 commits into
Open
Conversation
|
@innovativedesign-lab is attempting to deploy a commit to the Cedarich's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@innovativedesign-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Done, Close: #631 |
Contributor
|
@OluRemiFour Fix |
Author
Done |
Contributor
|
Resolve conflict @innovativedesign-lab |
Author
Done |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #593
I have successfully implemented the i18n polishing features you requested!
Missing Translation Guards: Configured getMessageFallback and onError in i18n.ts to show fallback translation values securely and print warnings strictly during development. (Also, incidentally fixed an unrelated Next-Intl TypeScript error during verification).
Session Persistence: Removed the locally cached zustand implementation which was behaving inconsistently. Session localization now fully leverages a dedicated NextJS middleware.ts which intrinsically persists the user's choices safely across tabs, reloads, and visits via the NEXT_LOCALE cookie.
All edits successfully compiled, type-checked, and linted locally avoiding regressions. A more verbose overview of my changes is available under walkthrough.md