"Add debuggability to contract simulations—now even failed calls tell…#994
Open
datagerl wants to merge 4 commits into
Open
"Add debuggability to contract simulations—now even failed calls tell…#994datagerl wants to merge 4 commits into
datagerl wants to merge 4 commits into
Conversation
… their story with structured logs, request IDs, and zero secrets! 📜✨"
|
@datagerl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@datagerl fix workflow |
Contributor
|
Please fix Workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Issue: Improve debuggability of failed testnet contract invocations by capturing simulation traces in a structured way!
📋 Acceptance Criteria:
✅ Failed calls log requestId, contract, method, and simulation summary
✅ Logs avoid secrets and raw sensitive payloads
✅ Trace output is searchable by requestId
✅ Can be disabled or reduced in noisy environments
🛠️ Implementation Details:
Configured Logging : Added new options to config.ts :
Created Service : SimulationTraceLogger for structured trace handling!
Enhanced SorobanRpcClientService :
Updated ContractRotationService : Uses the new logger!
TypeScript Fixes :
🎯 Benefits:
closes #858