feat: implement Testnet account bootstrap endpoint using Friendbot s…#1002
Open
nikkybel wants to merge 2 commits into
Open
feat: implement Testnet account bootstrap endpoint using Friendbot s…#1002nikkybel wants to merge 2 commits into
nikkybel wants to merge 2 commits into
Conversation
|
@nikkybel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@nikkybel fix workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
The bootstrapAccount endpoint (POST /stellar/bootstrap) now fully satisfies the acceptance criteria:
@UseGuards(JwtAuthGuard) + @ApiBearerAuth — requires a valid JWT, blocking unauthenticated abuse
this.config.network !== 'testnet' check — throws 403 ForbiddenException if the running network is mainnet, making the guard environment-aware
isEnabled() check returns 403 ForbiddenException (was incorrectly 401 UnauthorizedException before)
@Throttle(getFriendbotBootstrapThrottleOverride()) — already wired to the friendbotBootstrap rate limit profile (5/hr dev, 3/hr staging, 2/hr prod)
@matches(/^G[A-Z2-7]{55}$/) on the DTO — validates the Stellar public key format at the request validation layer before it even hits the service
.env.example comment updated to make the testnet-only constraint and the "never enable in production" intent explicit
close #843