Add chi_check to chi_pad - #191
Open
Moohan wants to merge 5 commits into
Open
Conversation
The function now accepts additional parameters for validation checks. It also includes warnings for invalid CHI numbers after padding. I left `chi_check` as `FALSE` to maintain backwards compatabilty but theres an argument for it being on by default, as there's no value to padding a CHI and it still being invalid.
Also add a gate to only apply padding when needed, i.e. at least one 9-character CHI
Moohan
marked this pull request as ready for review
September 1, 2026 16:10
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function now accepts additional parameters for validation checks. It also includes warnings for invalid CHI numbers after padding.
I left
chi_checkasFALSEto maintain backwards compatibility, but there's an argument for it being on by default, as there's no value to padding a CHI and it still being invalid.Closes #184