Conversation
This data is used in the `match_area()` function. I think we have spoken previously about deprecating that function (and so the `area_lookup` data too.
In the meantime, I wanted to make it work without the magrittr pipe `%>%` ... It wasn't that simple as the `{SPARQL}` package was removed from CRAN > 4 years ago, and the query didn't work anymore either.
I've overhauled the script, so 1) it's working and 2) as far as I can tell is as close as possible to the old behaviour. One change will be that area names with non-ASCII characters now seem to work, so I've just left them in; previously, the query wasn't returning them, so full ASCII versions of the names were being hardcoded.
I also added some tests to make comparing future updates of this simpler!
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This data is used in the
match_area()function. I think we have spoken previously about deprecating that function (and so thearea_lookupdata too.In the meantime, I wanted to make it work without the magrittr pipe
%>%... It wasn't that simple as the{SPARQL}package was removed from CRAN > 4 years ago, and the query didn't work anymore either.I've overhauled the script, so 1) it's working and 2) as far as I can tell is as close as possible to the old behaviour. One change will be that area names with non-ASCII characters now seem to work, so I've just left them in; previously, the query wasn't returning them, so full ASCII versions of the names were being hardcoded.
I also added some tests to make comparing future updates of this simpler!