Skip to content

fix(BRIDGE-610): structurally compare literals if byte-for-byte comparison fails - #480

Merged
annatar merged 2 commits into
devfrom
fix/bridge-610
Aug 4, 2026
Merged

fix(BRIDGE-610): structurally compare literals if byte-for-byte comparison fails#480
annatar merged 2 commits into
devfrom
fix/bridge-610

Conversation

@annatar

@annatar annatar commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Add a structural equivalence check before deciding on whether to update or create a new literal.

@ElectroNafta ElectroNafta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done!

A couple of things to note:

  • I think we filter out display names for the message hash. So changes in the display names won't be taken into account. Not a real issue, and extremely hard to hit. But perhaps worth opening up a ticket just so we know of the debt. We may need to tweak it further down.
  • We don't tolerate MIME part re-ordering, which may happen in some cases. This was already part of the code for a long time so it shouldn't pose an issue, but something to be aware of.

@annatar
annatar merged commit 5e16fef into dev Aug 4, 2026
4 checks passed
@annatar
annatar deleted the fix/bridge-610 branch August 4, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants