fix(BRIDGE-610): structurally compare literals if byte-for-byte comparison fails - #480
Merged
Conversation
xmichelo
approved these changes
Jul 24, 2026
ElectroNafta
approved these changes
Aug 4, 2026
ElectroNafta
left a comment
Contributor
There was a problem hiding this comment.
Very nicely done!
A couple of things to note:
- I think we filter out display names for the message hash. So changes in the display names won't be taken into account. Not a real issue, and extremely hard to hit. But perhaps worth opening up a ticket just so we know of the debt. We may need to tweak it further down.
- We don't tolerate MIME part re-ordering, which may happen in some cases. This was already part of the code for a long time so it shouldn't pose an issue, but something to be aware of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a structural equivalence check before deciding on whether to update or create a new literal.