Skip to content

fix: UID SEARCH on an empty mailbox must match nothing, not answer NO #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akeemjenkins wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: UID SEARCH on an empty mailbox must match nothing, not answer NO #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2522292
fix: UID SEARCH on an empty mailbox must match nothing, not fail
akeemjenkins Jul 9, 2026
65f0a4e
Merge branch 'dev' into fix/uid-search-empty-mailbox
annatar Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/state/snapshot_messages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,14 @@ func (list *snapMsgList) resolveSeqInterval(seqSet []command.SeqRange) ([]SeqInt
}

func (list *snapMsgList) resolveUIDInterval(seqSet []command.SeqRange) ([]UIDInterval, error) {
// An empty mailbox contains no UIDs, so any UID set matches nothing.
// Resolving against the empty snapshot would report ErrNoSuchMessage
// instead, turning e.g. a UID SEARCH on an empty mailbox into a NO reply;
// RFC 3501 requires non-existent UIDs to be ignored without error.
if list.len() == 0 {
return nil, nil
}

res := make([]UIDInterval, 0, len(seqSet))

for _, uidRange := range seqSet {
Expand Down
22 changes: 22 additions & 0 deletions tests/search_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,28 @@ func TestSearchUID(t *testing.T) {
})
}

func TestSearchUIDEmptyMailbox(t *testing.T) {
runOneToOneTestWithAuth(t, defaultServerOptions(t), func(c *testConnection, s *testSession) {
c.C(`A001 select inbox`).OK("A001")

// RFC 3501 section 6.4.8: "A non-existent unique identifier is
// ignored without any error message generated." In an empty mailbox
// every UID is non-existent, so a UID key matches nothing; it must
// not turn the SEARCH into a NO reply.
c.C(`A002 uid search uid 1`)
c.S("* SEARCH")
c.OK("A002")

c.C(`A003 search uid 1,3:5`)
c.S("* SEARCH")
c.OK("A003")

c.C(`A004 uid search uid 1:*`)
c.S("* SEARCH")
c.OK("A004")
})
}

func TestSearchUIDAfterDelete(t *testing.T) {
runOneToOneTestWithData(t, defaultServerOptions(t), func(c *testConnection, s *testSession, mbox string, mboxID imap.MailboxID) {
// Remove some messages to ensure sequence doesn't match uid
Expand Down
Loading