Skip to content

Fixes #538: smarty error: undefined modifier @key #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dontub merged 1 commit into from
Jun 1, 2026
Merged

Fixes #538: smarty error: undefined modifier @key #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CRM/Banking/PluginImpl/Matcher/RecurringContribution.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@
// assign to smarty and compile HTML
$smarty_vars['recurring_contributions'] = $rcontributions;
$smarty_vars['contacts'] = $contacts;
$smarty_vars['contact_id'] = array_key_first($contacts);
$smarty_vars['penalties'] = $match->getEvidence();

$smarty = CRM_Banking_Helpers_Smarty::singleton();
Expand Down Expand Up @@ -673,7 +674,7 @@
0,
0,
0,
(int) date('n', $start_date) + (int) (date('j', $start_date) > $cycle_day),

Check failure on line 677 in CRM/Banking/PluginImpl/Matcher/RecurringContribution.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-stable 

Greater: string ('1'|'10'|'11'|'12'|'13'|'14'|'15'|'16'|'17'|'18'|'19'|'2'|'20'|'21'|'22'|'23'|'24'|'25'|'26'|'27'|'28'|'29'|'3'|'30'|'31'|'4'|'5'|'6'|'7'|'8'|'9') in combination with non-string (int) is not allowed.

Check failure on line 677 in CRM/Banking/PluginImpl/Matcher/RecurringContribution.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-lowest 

Greater: string ('1'|'10'|'11'|'12'|'13'|'14'|'15'|'16'|'17'|'18'|'19'|'2'|'20'|'21'|'22'|'23'|'24'|'25'|'26'|'27'|'28'|'29'|'3'|'30'|'31'|'4'|'5'|'6'|'7'|'8'|'9') in combination with non-string (int) is not allowed.

Check failure on line 677 in CRM/Banking/PluginImpl/Matcher/RecurringContribution.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.4 prefer-stable 

Greater: string ('1'|'10'|'11'|'12'|'13'|'14'|'15'|'16'|'17'|'18'|'19'|'2'|'20'|'21'|'22'|'23'|'24'|'25'|'26'|'27'|'28'|'29'|'3'|'30'|'31'|'4'|'5'|'6'|'7'|'8'|'9') in combination with non-string (int) is not allowed.
$cycle_day,
(int) date('Y', $start_date));

Expand All @@ -697,8 +698,8 @@
}
$last = strtotime($last_contribution['receive_date']);
$last_month = strtotime('-1 month', $last);
$cycle_day_after = mktime(0, 0, 0, (int) date('n', $last) + (int) (date('j', $last) > $cycle_day), $cycle_day, (int) date('Y', $last));

Check failure on line 701 in CRM/Banking/PluginImpl/Matcher/RecurringContribution.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-stable 

Greater: string ('1'|'10'|'11'|'12'|'13'|'14'|'15'|'16'|'17'|'18'|'19'|'2'|'20'|'21'|'22'|'23'|'24'|'25'|'26'|'27'|'28'|'29'|'3'|'30'|'31'|'4'|'5'|'6'|'7'|'8'|'9') in combination with non-string (int) is not allowed.

Check failure on line 701 in CRM/Banking/PluginImpl/Matcher/RecurringContribution.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-lowest 

Greater: string ('1'|'10'|'11'|'12'|'13'|'14'|'15'|'16'|'17'|'18'|'19'|'2'|'20'|'21'|'22'|'23'|'24'|'25'|'26'|'27'|'28'|'29'|'3'|'30'|'31'|'4'|'5'|'6'|'7'|'8'|'9') in combination with non-string (int) is not allowed.

Check failure on line 701 in CRM/Banking/PluginImpl/Matcher/RecurringContribution.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.4 prefer-stable 

Greater: string ('1'|'10'|'11'|'12'|'13'|'14'|'15'|'16'|'17'|'18'|'19'|'2'|'20'|'21'|'22'|'23'|'24'|'25'|'26'|'27'|'28'|'29'|'3'|'30'|'31'|'4'|'5'|'6'|'7'|'8'|'9') in combination with non-string (int) is not allowed.
$cycle_day_before = mktime(0, 0, 0, (int) date('n', $last_month) + (int) (date('j', $last_month) > $cycle_day), $cycle_day, (int) date('Y', $last_month));

Check failure on line 702 in CRM/Banking/PluginImpl/Matcher/RecurringContribution.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-stable 

Greater: string ('1'|'10'|'11'|'12'|'13'|'14'|'15'|'16'|'17'|'18'|'19'|'2'|'20'|'21'|'22'|'23'|'24'|'25'|'26'|'27'|'28'|'29'|'3'|'30'|'31'|'4'|'5'|'6'|'7'|'8'|'9') in combination with non-string (int) is not allowed.

Check failure on line 702 in CRM/Banking/PluginImpl/Matcher/RecurringContribution.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-lowest 

Greater: string ('1'|'10'|'11'|'12'|'13'|'14'|'15'|'16'|'17'|'18'|'19'|'2'|'20'|'21'|'22'|'23'|'24'|'25'|'26'|'27'|'28'|'29'|'3'|'30'|'31'|'4'|'5'|'6'|'7'|'8'|'9') in combination with non-string (int) is not allowed.

Check failure on line 702 in CRM/Banking/PluginImpl/Matcher/RecurringContribution.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.4 prefer-stable 

Greater: string ('1'|'10'|'11'|'12'|'13'|'14'|'15'|'16'|'17'|'18'|'19'|'2'|'20'|'21'|'22'|'23'|'24'|'25'|'26'|'27'|'28'|'29'|'3'|'30'|'31'|'4'|'5'|'6'|'7'|'8'|'9') in combination with non-string (int) is not allowed.
if (abs($last - $cycle_day_before) < abs($last - $cycle_day_after)) {
$last_cycle_date = $cycle_day_before;
}
Expand Down
2 changes: 0 additions & 2 deletions templates/CRM/Banking/PluginImpl/Matcher/RecurringContribution.suggestion.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<div>
<p>
{if $recurring_contributions|@count eq 1}
{assign var=contact_id value=$contacts|@key}
{assign var=contact value=$contacts.$contact_id}
{capture assign=address_text}{if $contact.city}{$contact.street_address}, {$contact.city}{else}{ts domain='org.project60.banking'}Address incomplete{/ts}{/if}{/capture}
{capture assign=contact_link}<a title="{$address_text}" href="{crmURL p="civicrm/contact/view" q="reset=1&cid=$contact_id"}">{$contact.display_name} [{$contact.id}]</a>{/capture}
Expand All @@ -27,7 +26,6 @@
{else}
{assign var=recurring_contribution_count value=$recurring_contributions|@count}
{if $contacts|@count eq 1}
{assign var=contact_id value=$contacts|@key}
{assign var=contact value=$contacts.$contact_id}
{capture assign=address_text}{if $contact.city}{$contact.street_address}, {$contact.city}{else}{ts domain='org.project60.banking'}Address incomplete{/ts}{/if}{/capture}
{capture assign=contact_link}<a title="{$address_text}" href="{crmURL p="civicrm/contact/view" q="reset=1&cid=$contact_id"}">{$contact.display_name} [{$contact.id}]</a>{/capture}
Expand Down
Loading