Conversation
eliebak
marked this pull request as ready for review
September 30, 2026 01:51
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5864229. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Direct Anthropic requests currently use Chat Completions, which does not support prompt caching. Route
api.anthropic.comthrough the native Messages API and enable automatic five-minute caching, with a separate system-prompt breakpoint for reuse across compaction.Add optional
api_format,prompt_cache(5m,1h, oroff), andmax_output_tokensprovider settings. Preserve native content and tool history, handle Anthropic retries, context overflows, and context-window discovery, and count cache writes toward token budgets while excluding cache reads. Full prompt usage still includes both for context management.Validation:
uv run pytest tests/: 338 passed; 5 opt-in live tests skipped.Note
Medium Risk
Changes the default inference path for Anthropic endpoints and token-budget accounting; mistakes could affect cost limits or break tool/compaction flows, though behavior is heavily tested.
Overview
Anthropic traffic now uses the native Messages API when
provider.base_urlisapi.anthropic.com(orapi_formatis"anthropic"), instead of Chat Completions, so prompt caching works. OpenAI-style chat history is converted in a new transport layer; responses are normalized back toChatCompletion, includinganthropic_contentfor faithful tool replay.The ACP provider contract gains
api_format(auto/openai/anthropic),prompt_cache(5m,1h,off), andmax_output_tokens. Requests set ephemeral cache controls (plus a system-prompt breakpoint for reuse after compaction). Treemax_total_tokensbilling treats cache reads as non-new work while still counting full prompt usage for compaction thresholds; Anthropic retries, overflow detection, and model context-window discovery (max_input_tokens) are wired through the shared client path.Documentation describes caching behavior and opt-in live tests;
anthropicis added as a dependency with unit and live test coverage.Reviewed by Cursor Bugbot for commit 5864229. Bugbot is set up for automated code reviews on this repo. Configure here.