Trim CLAUDE.md to repo-specific facts, point to ai/CLAUDE.md for methodology - #42
Conversation
…odology The general schema=-vs-relocatable= explanation, the two-part search_path-exclusion proof, and the SCHEMA-clause-vs-search_path-mutation guidance are now in Postgres-Extensions/ai's CLAUDE.md (Schema-flexibility testing section) -- not specific to this repo. Also drops the pointer to container-local docs (~/advanced-extension-testing.md, ~/test-fixes.md) that nothing outside that one session could resolve; their substance is what moved to ai/CLAUDE.md. Corrects a wrong claim along the way: extension_drop's install SQL doesn't use @extschema@ -- it pins search_path via `SET search_path FROM CURRENT` on each permanent function instead, and its one CREATE SCHEMA is transient scaffolding, dropped within the same script.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @jnasbyupgrade's task in 2m 20s —— View job Code Review: PR #42 — Trim CLAUDE.md to repo-specific factsTasks
SummaryThis is a documentation-only change ( Verification of the factual correctionThe PR description claims the old text was wrong about
The new wording in Other observations
Overall this looks like a clean, well-scoped documentation trim with a verified factual fix. No blocking issues found. |
extension_drop isn't pinned to a fixed schema, so the random-schema testing conventions apply here -- this repo already has a working TEST_SCHEMA implementation (see the top-level CLAUDE.md's Schema independence section).
28d0450
into
Postgres-Extensions:master
The general schema=-vs-relocatable= explanation, the two-part search_path-exclusion proof, and the SCHEMA-clause-vs-search_path-mutation guidance are now in Postgres-Extensions/ai's test/CLAUDE.md and RANDOM_SCHEMA_TESTING.md (ai#5) — not specific to this repo. Also drops the pointer to container-local docs (~/advanced-extension-testing.md, ~/test-fixes.md) that nothing outside that one session could resolve; their substance is what moved to ai/.
Adds test/CLAUDE.md here referencing both new ai/ docs, since extension_drop isn't pinned to a fixed schema.
Corrects a wrong claim along the way: extension_drop's install SQL doesn't use @extschema@ — it pins search_path via SET search_path FROM CURRENT on each permanent function instead, and its one CREATE SCHEMA is transient scaffolding, dropped within the same script.