Bump minimum supported PostgreSQL to 12 - #27
Open
jnasbyupgrade wants to merge 3 commits into
Open
Conversation
Drops CI matrix legs and the declared floor for PG 9.3-11. Not an arbitrary cut: cat_tools already declares 12.0 as its own floor, and extension_drop depends on cat_tools, so those older versions were never really supported once on a cat_tools version new enough to provide the functions extension_drop actually calls.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops CI matrix legs and the declared floor for PG 9.3-11.
Not an arbitrary cut: cat_tools already declares 12.0 as its own
requirement (see its
META.in.json), and extension_drop depends oncat_tools. This surfaced concretely while folding update-path testing
into the main test job (#22):
cat_tools.routine__parse_arg_types_text()-- called unconditionally by extension_drop's install script, in both
its 0.1.1 release and current source -- hits a hardcoded
DROP ROUTINEinside cat_tools that doesn't exist before PG11. So a fresh install of
current extension_drop has actually been broken on PG9.3-10 this whole
time, just never caught by this repo's non-gating CI. Rather than
special-case around it, just stop claiming support for PG versions
cat_tools itself doesn't support.