feat: Add FlagDefinitionCacheProvider interface #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
dustinbyrne
force-pushed
the
feat/external-flag-cache
branch
2 times, most recently
from
cd2f61d to
e1c2266
Compare
dustinbyrne
force-pushed
the
feat/external-flag-cache
branch
from
e1c2266 to
c6c2f64
Compare
dmarticus
approved these changes
Dec 11, 2025
Contributor
dmarticus
left a comment
dmarticus
left a comment
There was a problem hiding this comment.
two minor things, but generally this is a great abstraction
The defined types don't leave room for missing or optional keys. We'll use the types as they're defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors PostHog/posthog-js#2594 / https://posthog.com/tutorials/node-external-cache
This addition allows users to implement their own custom external caching solutions for local evaluation / flag definitions. Implementations would allow for distributed caching of flags definitions, such that one logical service can poll from a single coordinated leader, while other individual instances rely on cached flag definitions while evaluating flags locally.
Example code provided featuring an implementation for Redis, complete with coordination to poll from a single instance.