feat: make deferred init default#2567
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f52510c to
f689fa1
Compare
There was a problem hiding this comment.
Additional Comments (12)
-
packages/browser/src/posthog-core.ts, line 543 (link)logic: property name changed to
deferred_init_extensionsbut old name still used here -
packages/browser/src/posthog-core.ts, line 737 (link)logic: property name changed to
deferred_init_extensionsbut old name still used here -
packages/browser/src/posthog-core.ts, line 768-770 (link)logic: property name changed to
deferred_init_extensionsbut old name still used here -
packages/browser/src/posthog-core.ts, line 773 (link)logic: property name changed to
deferred_init_extensionsbut old name still used here -
packages/browser/src/posthog-core.ts, line 788 (link)logic: property name changed to
deferred_init_extensionsbut old name still used here -
packages/browser/src/__tests__/deferred-init-extensions.test.ts, line 52 (link)logic: update to use new property name
deferred_init_extensions -
packages/browser/src/__tests__/deferred-init-extensions.test.ts, line 80 (link)logic: update to use new property name
deferred_init_extensions -
packages/browser/src/__tests__/deferred-init-extensions.test.ts, line 103 (link)logic: update to use new property name
deferred_init_extensions -
packages/browser/src/__tests__/deferred-init-extensions.test.ts, line 123 (link)logic: update to use new property name
deferred_init_extensions -
packages/browser/src/__tests__/deferred-init-extensions.test.ts, line 152 (link)logic: update to use new property name
deferred_init_extensions -
packages/browser/src/__tests__/deferred-init-extensions.test.ts, line 165 (link)logic: update to use new property name
deferred_init_extensions -
playground/nextjs/src/posthog.ts, line 84 (link)logic: update to use new property name
deferred_init_extensions
3 files reviewed, 12 comments
f689fa1 to
cc4f639
Compare
|
Size Change: -5.97 kB (-0.12%) Total Size: 4.98 MB
ℹ️ View Unchanged
|
lricoy
left a comment
There was a problem hiding this comment.
Question: is it ok then to break the __preview* options? I always assumed so but wasn't 100% sure.
|
yeah, i think if you use something that's "preview" then it's fine to break it. especially this will have only been there a few days, we should always avoid things like that if we can but... |
|
@pauldambra forgot to comment, but you're missing a changeset and the release label if you want to generate a release with this one already |
3667e63 to
d207e2c
Compare
0ec2b50 to
4d6726f
Compare
rafaeelaudibert
left a comment
There was a problem hiding this comment.
Would love a follow-up where we kind of write the code in a way where it reads as if true was the default rather than the current way where it's clearly "an after thought".
|
i don't follow... |
d207e2c to
8d521f5
Compare
@pauldambra what exactly? Was this for me or @rafaeelaudibert ? -- nevermind, I replied directly from the notification |
e3c6e2b to
4b1dde6
Compare
bb35ee8 to
6f2baf7
Compare
1952b69 to
0fd320c
Compare
0fd320c to
9bd25b7
Compare
9bd25b7 to
080f970
Compare
a280171 to
c8c7de2
Compare
080f970 to
7ec266a
Compare
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |


Problem
a user reports that they have strict performance requirements and posthog was blocking too much.
in 1.290.1 we released deferred init behind a flag
for our use of posthog this made our INP measurement much less variable
Changes
sets the default value to true for defaults 2025-11
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file