Skip to content

feat(client): support Binance price provider - #499

Merged
kartojal merged 1 commit into
mainfrom
feat/binance-price-provider
Nov 5, 2026
Merged

kartojal merged 1 commit into
mainfrom
feat/binance-price-provider

Conversation

@kartojal

@kartojal kartojal commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Allow client.subscribe([{ topic: 'prices.crypto', symbols: ['btcusd'], provider: PriceProvider.Binance }]) to opt into Binance spot prices. Add Binance to known price sources and document its USDT close values under canonical USD symbols. Existing defaults are unchanged.

Validation: workspace build, lint, and typecheck passed. 95 focused bindings, socket, and public type tests passed, covering acknowledgements, snapshots/live updates, provider filters through reconnect and unsubscribe, and public exports. Includes a patch changeset for bindings and client. No live authenticated feed test was run.


Note

Low Risk
Additive enum and documentation changes with expanded tests; default subscriptions and legacy RTDS topics are unchanged.

Overview
Adds Binance as an opt-in PriceProvider and KnownPriceSource on the PolyBolt price bindings and public client types, with a patch changeset for @polymarket/bindings and @polymarket/client.

Callers can pass provider: PriceProvider.Binance on secure prices.crypto subscriptions to request Binance USDT spot closes mapped to canonical USD symbols (e.g. btcusd); omitting provider keeps the previous default. Docs note that the pin is intended for crypto spot only and that acknowledgements and payload source should be checked when a pin may fall back.

Tests and type contracts now treat binance like other known providers/sources (ack parsing, wire normalization, subscribe filter encoding on reconnect/unsubscribe, and PriceProvider union exports).

Reviewed by Cursor Bugbot for commit 458f5cd. Bugbot is set up for automated code reviews on this repo. Configure here.

@kartojal
kartojal marked this pull request as ready for review November 5, 2026 08:30
@kartojal
kartojal merged commit be694f3 into main Nov 5, 2026
8 checks passed
@kartojal
kartojal deleted the feat/binance-price-provider branch November 5, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants