Repository navigation
feat(client): support Binance price provider - #499
Merged
Merged
Conversation
kartojal
marked this pull request as ready for review
November 5, 2026 08:30
cesarenaldi
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
client.subscribe([{ topic: 'prices.crypto', symbols: ['btcusd'], provider: PriceProvider.Binance }])to opt into Binance spot prices. Add Binance to known price sources and document its USDT close values under canonical USD symbols. Existing defaults are unchanged.Validation: workspace build, lint, and typecheck passed. 95 focused bindings, socket, and public type tests passed, covering acknowledgements, snapshots/live updates, provider filters through reconnect and unsubscribe, and public exports. Includes a patch changeset for bindings and client. No live authenticated feed test was run.
Note
Low Risk
Additive enum and documentation changes with expanded tests; default subscriptions and legacy RTDS topics are unchanged.
Overview
Adds Binance as an opt-in
PriceProviderandKnownPriceSourceon the PolyBolt price bindings and public client types, with a patch changeset for@polymarket/bindingsand@polymarket/client.Callers can pass
provider: PriceProvider.Binanceon secureprices.cryptosubscriptions to request Binance USDT spot closes mapped to canonical USD symbols (e.g.btcusd); omittingproviderkeeps the previous default. Docs note that the pin is intended for crypto spot only and that acknowledgements and payloadsourceshould be checked when a pin may fall back.Tests and type contracts now treat
binancelike other known providers/sources (ack parsing, wire normalization, subscribe filter encoding on reconnect/unsubscribe, andPriceProviderunion exports).Reviewed by Cursor Bugbot for commit 458f5cd. Bugbot is set up for automated code reviews on this repo. Configure here.