Repository navigation
Conversation
This was referenced Oct 22, 2026
kartojal
force-pushed
the
feat/predictions-action-routing
branch
from
October 22, 2026 15:28
23c8ccb to
1abf001
Compare
kartojal
force-pushed
the
feat/predictions-action-routing
branch
2 times, most recently
from
October 23, 2026 13:19
4c0fc15 to
66c975f
Compare
kartojal
marked this pull request as ready for review
October 26, 2026 14:08
kartojal
force-pushed
the
feat/predictions-action-routing
branch
from
October 27, 2026 17:54
be4fe22 to
1c2792a
Compare
kartojal
force-pushed
the
feat/predictions-action-routing
branch
2 times, most recently
from
November 2, 2026 16:55
9383470 to
c99441d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c99441d. Configure here.
Keep order heartbeats on the direct V1 endpoint until the gateway serves the V1 heartbeat contract. API keys now sign only the Predictions operations of their credential family, so relayer keys and remote builder signing no longer reach discovery, portfolio or trading reads. Remove the unused L2 signing branch and the orphaned builder gateway and collateral transports. Replace the mocked routing suite with pure signing tests and live integration coverage, and point the integration URL assertions at the gateway routes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The closed filter check needs a few continuation pages, not a hundred. The gateway hop adds about 0.1 s per full page, so a hundred-page walk exceeds the integration timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The accounting snapshot download is no longer part of the SDK, so the routing notes and changeset no longer list it as a direct endpoint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kartojal
force-pushed
the
feat/predictions-action-routing
branch
from
November 3, 2026 17:52
0f19e7c to
ebb8ddc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Routes existing discovery, pricing, account, trading, portfolio, wallet and combo SDK methods through supported Predictions routes. Saved L2 credentials migrate to bearer credentials before business requests. Perps and WebSocket transports remain separate.
Routing follows the DeFi Gateway passthrough tables at master
5d031a59. Keyset comments use/v1/commentsand its cursor envelope. Two operations keep their direct endpoints because the Gateway has no equivalent: offset-only comment filters with legacy offset cursors, and order heartbeats. The Gateway still forwards/v1/trading/heartbeatsto legacy/heartbeats, which returns{status:"ok"}and reads only L2 credentials. SosendOrderHeartbeatstays on/v1/heartbeatsuntil the Gateway serves the V1 contract. No new public SDK methods were added for Gateway-only endpoints.API keys sign only the operations of their credential family, against the upstream method and path. Builder keys sign trading operations and builder RFQ writes. Keys that support gasless transactions sign wallet, collateral return and session-signer operations. Discovery, Gamma, Data and auth requests carry no API-key headers, so a relayer key or a remote builder signer no longer runs on every read. Request query, body, pagination and Blob responses stay intact. Routing decisions occur before dispatch, with no automatic fallback on failure.
The unused L2 signing branch is gone, along with the builder gateway and collateral transports that no action uses after the move.
Tests follow AGENTS.md.
prediction-signing.test.tscovers the signing table as a pure function, with no client or mocked responses. Routing proof and the activity query cases moved to the live integration suite withfetchspies. The integration URL assertions now name the Gateway routes, and the live event walk stops at 20 pages because each Gateway page adds about 0.1 s.Inherits #437's setup-failure session revocation and deferred new-session credential notifications.
Stack: #442 → #481 → #437 → #463 → #438 → #441. Restacked onto main on 2026-11-03 after #448 removed the accounting snapshot download.
Validation on 2026-11-03: build, lint and workspace typecheck pass, and 1,101 client tests pass. The live integration suites for the moved public reads pass against production. The exceptions are two holder-comment depth tests, which fail the same way on the #437 base. Suites that need wallet secrets were not run. Live production checks on the previous head covered signed login, automatic saved-L2 migration, authenticated order, trade, notification, trading-status and balance-allowance reads, bearer refresh and logout. No trading, transfers, approvals or wallet deployment were performed.
Human reviews and unresolved review threads remain outstanding.
Note
Cursor Bugbot is generating a summary for commit ebb8ddc. Configure here.