Repository navigation
feat(streams): support Binance price provider - #405
Merged
Merged
Conversation
kartojal
marked this pull request as ready for review
November 4, 2026 19:16
cesarenaldi
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
CryptoPriceSpec(symbols=["btcusd"], provider="binance")andKnownPriceSource.BINANCEto opt into Binance spot prices. Recognize Binance in snapshots and live updates while preserving exact prices and existing defaults.Verified against PolyBolt d362362ca8438f2741ba5acb8a4fe3ae91fc8da7 (README provider selector contract). Binance serves USDT pair closes verbatim under canonical USD symbols on
price.crypto. Other price channels accept the pin and fall back to their configured owner; callers should inspect payloadsource.Make the existing pending-reconnect test deterministic: a 30-second backoff cap can draw near-zero jitter and reconnect before the second subscription. Fix the delay in that test and wait for the reconnect timer to be queued. Production reconnect behavior is unchanged.
Validation: 331 related realtime price, CLOB market stream, and reconnect tests passed. Ruff check, format check, and Pyright passed. Full local non-integration run: 3582 passed; two unrelated wallet-default tests failed on live
/deployedconnection errors. No live authenticated price feed test was run.