Repository navigation
feat(data)!: remove retired accounting snapshot download - #370
Merged
Merged
Conversation
kartojal
marked this pull request as ready for review
November 2, 2026 09:22
cesarenaldi
approved these changes
Nov 2, 2026
cesarenaldi
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the accounting snapshot removal across public and secure sync/async clients and the shared request builder. No blockers found. The breaking removal is documented in the changelog. Local lint, formatting, typecheck, build, and 3,560 non-integration tests passed; CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
download_accounting_snapshotfromPublicClient,SecureClient,AsyncPublicClient, andAsyncSecureClientas part of the Data API v1 cleanup. Delete its shared request builder and snapshot-only tests while preserving the surrounding portfolio and request-boundary coverage.Breaking migration: remove calls to this method. There is no V2 replacement for its ZIP/CSV archive; portfolio, position, and activity reads are not equivalent accounting exports. An Unreleased changelog entry records the removal, which should ship in a minor release on the 0.x line. No package version is changed or release prepared here.
Inventory: the remaining 20 distinct Data API routes, including indexed approvals, already use
/v2and match the current public OpenAPI contract. CLOB, Gamma, relayer, RFQ, and Perps calls are outside this retirement. Historical changelog entries are preserved.Companion documentation: https://github.com/Polymarket/docs/pull/525. API removal and release timing require human review; do not merge or release as part of this cleanup.
Note
Medium Risk
Breaking public API removal affects integrators relying on accounting ZIP exports, though scope is limited to one retired v1 route with no runtime behavior change elsewhere.
Overview
Breaking change: Removes
download_accounting_snapshotfrom all four data clients (PublicClient,SecureClient, and their async variants) and deletes the internalbuild_accounting_snapshot_requesthelper that targeted/v1/accounting/snapshot.Callers must drop uses of this method. There is no Data API v2 replacement for the ZIP/CSV accounting archive; portfolio, position, and activity reads are not equivalent exports. An Unreleased changelog entry documents the removal.
Related integration, unit spec, and secure-client default-user tests for the snapshot download are removed; other data coverage is unchanged.
Reviewed by Cursor Bugbot for commit 2118eb4. Bugbot is set up for automated code reviews on this repo. Configure here.