Skip to content

feat(data)!: remove retired accounting snapshot download - #370

Merged
kartojal merged 3 commits into
mainfrom
cleanup/data-api-v1-retirement-20261021
Nov 2, 2026
Merged

kartojal merged 3 commits into
mainfrom
cleanup/data-api-v1-retirement-20261021

Conversation

@kartojal

@kartojal kartojal commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Remove download_accounting_snapshot from PublicClient, SecureClient, AsyncPublicClient, and AsyncSecureClient as part of the Data API v1 cleanup. Delete its shared request builder and snapshot-only tests while preserving the surrounding portfolio and request-boundary coverage.

Breaking migration: remove calls to this method. There is no V2 replacement for its ZIP/CSV archive; portfolio, position, and activity reads are not equivalent accounting exports. An Unreleased changelog entry records the removal, which should ship in a minor release on the 0.x line. No package version is changed or release prepared here.

Inventory: the remaining 20 distinct Data API routes, including indexed approvals, already use /v2 and match the current public OpenAPI contract. CLOB, Gamma, relayer, RFQ, and Perps calls are outside this retirement. Historical changelog entries are preserved.

Companion documentation: https://github.com/Polymarket/docs/pull/525. API removal and release timing require human review; do not merge or release as part of this cleanup.


Note

Medium Risk
Breaking public API removal affects integrators relying on accounting ZIP exports, though scope is limited to one retired v1 route with no runtime behavior change elsewhere.

Overview
Breaking change: Removes download_accounting_snapshot from all four data clients (PublicClient, SecureClient, and their async variants) and deletes the internal build_accounting_snapshot_request helper that targeted /v1/accounting/snapshot.

Callers must drop uses of this method. There is no Data API v2 replacement for the ZIP/CSV accounting archive; portfolio, position, and activity reads are not equivalent exports. An Unreleased changelog entry documents the removal.

Related integration, unit spec, and secure-client default-user tests for the snapshot download are removed; other data coverage is unchanged.

Reviewed by Cursor Bugbot for commit 2118eb4. Bugbot is set up for automated code reviews on this repo. Configure here.

@kartojal
kartojal marked this pull request as ready for review November 2, 2026 09:22

@cesarenaldi cesarenaldi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the accounting snapshot removal across public and secure sync/async clients and the shared request builder. No blockers found. The breaking removal is documented in the changelog. Local lint, formatting, typecheck, build, and 3,560 non-integration tests passed; CI is green.

@kartojal
kartojal merged commit 9240360 into main Nov 2, 2026
7 checks passed
@kartojal
kartojal deleted the cleanup/data-api-v1-retirement-20261021 branch November 2, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants