Fix missing icons on page 2 by improving icon streaming and cache fal…#39
Open
juanxcueva wants to merge 1 commit intoPoloNX:masterfrom
Open
Fix missing icons on page 2 by improving icon streaming and cache fal…#39juanxcueva wants to merge 1 commit intoPoloNX:masterfrom
juanxcueva wants to merge 1 commit intoPoloNX:masterfrom
Conversation
Owner
|
Hello, thank you for your pull request. A fix has already been proposed in #35. I think the approach with smart pointers is more logical |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where page 2 could show missing/blank game icons while other pages loaded correctly.
Changes
Icon streaming:
App list loading:
libnxtccache entries when icon bytes are missingnsGetApplicationControlDatato refresh icon dataFiles changed
Validation
xmake -v(devkitA64)xmake install -o build/sd_outsdmc:/config/SwitchU/applist.bin