Ensure CoilCurvature and CoilTorsion are resolution independent - #2302
Ensure CoilCurvature and CoilTorsion are resolution independent#2302singh-jaydeep wants to merge 6 commits into
Conversation
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | -0.03 % | 4.239e+03 | 4.238e+03 | -1.35 | 30.60 | 28.79 |
test_proximal_jac_w7x_with_eq_update | -0.25 % | 6.848e+03 | 6.831e+03 | -16.88 | 151.43 | 152.48 |
test_proximal_freeb_jac | 0.03 % | 1.354e+04 | 1.355e+04 | 4.68 | 77.91 | 79.64 |
test_proximal_freeb_jac_blocked | 0.25 % | 7.879e+03 | 7.899e+03 | 19.96 | 69.94 | 68.35 |
test_proximal_freeb_jac_batched | -0.24 % | 7.878e+03 | 7.860e+03 | -18.53 | 69.79 | 67.79 |
test_proximal_jac_ripple | -0.85 % | 3.848e+03 | 3.815e+03 | -32.69 | 53.58 | 51.46 |
test_proximal_jac_ripple_bounce1d | 0.03 % | 4.026e+03 | 4.028e+03 | 1.30 | 67.04 | 66.56 |
test_eq_solve | 1.83 % | 1.801e+03 | 1.834e+03 | 32.88 | 52.84 | 52.36 |
test_objective_quadratic_flux_jac | 0.70 % | 1.881e+03 | 1.894e+03 | 13.26 | 35.08 | 35.16 |For the memory plots, go to the summary of |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2302 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 101 101
Lines 29053 29053
=======================================
Hits 27415 27415
Misses 1638 1638
🚀 New features to boost your workflow:
|
|
Can you also rerun the coil optimization notebook? Just so that they are up to date with master in case any minor changes have occurred |
Co-authored-by: Yigit Gunsur Elmacioglu <102380275+YigitElma@users.noreply.github.com>
|
View / edit / reply to this conversation on ReviewNB YigitElma commented on 2026-09-03T19:52:21Z Line #64. LinkingCurrentConsistency(eq, coilset, eq_fixed=True, jac_chunk_size=5), Any specific reason for adding additional constraint? |
|
View / edit / reply to this conversation on ReviewNB YigitElma commented on 2026-09-03T19:52:22Z I guess new constraint and weight caused this, but still this is a weirdly small number. |
|
View / edit / reply to this conversation on ReviewNB YigitElma commented on 2026-09-03T19:52:23Z These are couple orders of magnitude higher compared to before. This optimization was never intended to be a proper one (I think it is here to show MixedCoilSet optimization only), so probably fine. |
YigitElma
left a comment
There was a problem hiding this comment.
Other than the additional constraint for mixed coilset optimization notebook seems to be very similar. Looks good to me. If you think the additional constraint is necessary I can approve.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Resolves #2301 by replacing
quad_weightswith their square roots for these objectives. Also strengthens the resolution independence test for coil objectives.