Merged
Conversation
…ghtController/FlightMCU/Include. Move Components.hpp to header since it contains the includes for Impl of various modules required by CubeRoverTopologyAppAc.hpp
…hed upstream with the TI FreeRTOS port
…5 and 26 on the fprime install tutorial (as of 9-27). Some questionable changes to get everything working..... Also a change to ComLogger that is TI ARM compiler specific and should be pushed upstream
…ing and LED B denotes low frequency rate group
…h s in .gitignore
lchomas
approved these changes
Oct 1, 2020
alecjprobst
approved these changes
Oct 1, 2020
lchomas
approved these changes
Oct 2, 2020
nrjbs87
approved these changes
Oct 4, 2020
Author
|
Since some of the timing can't be tested above the HAL without external resources, added tests TIME1 and TIME2 to hardware in the loop document. |
justinnuwin
commented
Oct 9, 2020
Author
justinnuwin
left a comment
There was a problem hiding this comment.
- FreeRTOS idle hook was modified to not perform no-ops anymore. Need to decide on rover operation during idle.
- Just a note for the future that Svc/BuffGndSockIf, Svc/UdpSender, Svc/UdpReceiver was removed from build list due to lack of socket support on FreeRTOS
Mikeydavidr
approved these changes
Oct 15, 2020
Mikeydavidr
left a comment
There was a problem hiding this comment.
Nothing jumped out when viewing the changes, and I was able to get it to compile. There are still some items I am trying to understand.
alecjprobst
approved these changes
Oct 15, 2020
Collaborator
alecjprobst
left a comment
There was a problem hiding this comment.
Looks good to me, surprised that we needed to up the rate group drivers that much but values make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors and their respective fixes:
Topology.hpp, soTopology.cppandApp/Main.cpp.Component.hppincludes these component *Impl so this include was moved toTopology.hpp.NAME_MAXorPATH_MAXinlimits.h. TODO: We may need to find a better value for, these as I just defined these macros with the values my 64-bit Linux machine uses.HOMEenvironmental variableTODO: Test that these values match wall clock timeSee Hardware In Loop Test documentCubeRoverTime component is not built: Remove all instances and connections to this component until it has been built and testedAdded back with c95a781 but includes CubeRoverTime directly rather than throughSvc/TimeTests: No unit tests for these changes, but @nrjbs87 and @alecjprobst were able to build the project without errors with these changes