Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add cp storage demo #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: add cp storage demo #16
Changes from all commits
45c3f0353d6acb85be291df6aabdFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additionalPrinterColumnsis a field of eachspec.versions[]entry in the Crossplane v2 XRD API, not a top-levelspecfield (seeCompositeResourceDefinitionVersionin the Crossplane v2 API). With this indentation, strict Kubernetes validation can reject the XRD or the columns are pruned/ignored, so the new platform manifest is not installed as intended; move the block under thev1alpha1version.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The composed storage account is always sent to
rg-crossplanedemo, while the existing deploy path replaces<RESOURCE_GROUP_NAME>and grants the provider identity access to the-ResourceGroupNamevalue (defaultrg-crossplane). In the normal demo deployment this resource group either does not exist or is not the one the identity was scoped to, soStorageAccountclaims fail even after the platform API is installed; make this a parameter/placeholder or match the deployment resource group.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This composition creates a v2 namespaced Account whose
providerConfigRefmust point at anazure.m.upbound.ioprovider config (the v2 Account CRD requireskindandname), but the deploy flow only appliesCrossplane/kubernetes/providers/provider-config.yamlasazure.upbound.io/v1beta1, kind: ProviderConfig. Because noazure.m.upbound.io/v1beta1 ClusterProviderConfignameddefaultis created, anydemo-storage.yamlXR will compose an Account that cannot resolve credentials; add the matching ClusterProviderConfig or reference a matching namespaced ProviderConfig.Useful? React with 👍 / 👎.