Skip to content

fix: align seek position and startTime handling#200

Merged
1Lucas1apk merged 3 commits intoPerformanC:devfrom
Tomato6966:dev
Apr 8, 2026
Merged

fix: align seek position and startTime handling#200
1Lucas1apk merged 3 commits intoPerformanC:devfrom
Tomato6966:dev

Conversation

@Tomato6966
Copy link
Copy Markdown
Contributor

Fix seeking issue. (untested yet)

seek requests were received, but the stream layer could lose the requested offset because position / startTime handling was inconsistent, so playback restarted at 0.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

All Contributors have signed the CLA. The PR is now allowed to be merged.
Posted by the CLA Assistant Lite bot.

@Tomato6966
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Tomato6966
Copy link
Copy Markdown
Contributor Author

I have tested it. and now it works.

@Tomato6966
Copy link
Copy Markdown
Contributor Author

Tomato6966 commented Apr 7, 2026

There is still a slight issue with seeking related to eqs. but i think this is a my issue from the implementation. or it's an issue with the sending of the position cause on lavalink it works...
but this should be handled seperately and isn't very important.

On lavalink in order to apply filters "instantly" you were required to run a seek right after the filters.
I seem to have found, that this is not required on nodelink. good job.

@1Lucas1apk 1Lucas1apk self-requested a review April 8, 2026 01:16
@1Lucas1apk 1Lucas1apk merged commit b3af86b into PerformanC:dev Apr 8, 2026
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2026
@1Lucas1apk
Copy link
Copy Markdown
Member

Thank you for the pull request and for finding the bug, I'm very grateful :) Have a great day!

@Tomato6966 Tomato6966 deleted the dev branch April 9, 2026 08:23
@Tomato6966 Tomato6966 restored the dev branch April 9, 2026 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants