Track friend additions in analytics - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
friend_addedproduct event for successful local and Live additionsUser impact
The Home analytics data can now show how often people add friends and whether the action happened in a local or Live activity. One form submission counts once, even when several friends are added. Names, IDs, activity data, and friend counts are never sent.
Validation
npm run typechecknpm run lintnpm run test:coverage— 281 tests, 100% coveragenpm run test:e2e— 13 passednpm run backend:resetnpm run test:backend— 121 passednpx supabase db advisors --local --type all --level warn --fail-on errornpm run build:pagesfriend_added | local | enwith no currency and a hashed session token