Added missing ES6 support for latest version of gulp#149
Open
adityaparab wants to merge 1 commit intoPatrickJS:masterfrom
adityaparab:master
Open
Added missing ES6 support for latest version of gulp#149adityaparab wants to merge 1 commit intoPatrickJS:masterfrom adityaparab:master
adityaparab wants to merge 1 commit intoPatrickJS:masterfrom
adityaparab:master
Conversation
| "type": "git", | ||
| "url": "https://github.com/angularclass/NG6-starter.git" | ||
| }, | ||
| "babel": { |
Collaborator
There was a problem hiding this comment.
We already have .babelrc, isn't it enough?
Maybe move content of .babelrc here and remove it?
Author
There was a problem hiding this comment.
Ideally, it should be enough to have it in .babelrc. Unfortunately, that didn't work for me. May be that is because I don't have babel installed globally.
Wouldn't be better if we have it at both places to ensure the build doesn't fail?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With latest version of gulp, we get following error when we build the application
Latest version of gulp doesn't automatically transpile gulpfile which is written in ES6.
We need additional dependecy
gulp-clifor latest version of gulp.Additionally, we also need to set babel preset config in either
.babelrcor in ourpackage.json.Added this in package.json as well.
Changed files