Repository navigation
Conversation
for more information, see https://pre-commit.ci
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md lists
task prqlc:pull-requestas the "before returning to user" check at about 30 seconds. From a coldtarget/, which is what every tend session starts with, it compiles all five bindings (test-allinprqlc/Taskfile.yaml) and then reruns the suite undercargo llvm-cov. That takes 10–30+ minutes. Sessions follow the instruction, wait on it, and then run the narrower suite anyway. This PR adds a note under the command: the 30-second figure assumes a warm build, and on a cold onetask prqlc:testplus clippy onprqlcis enough before pushing, since CI runs the full suite.It's a doc-only change. The note goes after the code block and leaves the heading line alone, so it doesn't overlap #6469's insertion just above. Whether CI sessions should skip the full task is the maintainer's call. If the preference is to keep running it, closing this is fine.
Evidence from nightly runs
All four outcomes were correct. The cost was runner time and session budget:
task prqlc:pull-requestran from 06:38 to 07:08. The session then stopped it ("The full task builds all bindings and is too slow") and rancargo nextest run -p prqlc-parser -p prqlc -p mdbook-prqlpluscargo clippy -p prqlc --all-targets, which finished in about 1.5 minutes. The whole run took 50 minutes.%on the sql.mysql target #6426.Earlier observations are in the review-runs tracking issues #6513 and #6394.