Skip to content

docs: note that task prqlc:pull-request takes 10–30 min from a cold build - #6549

Open
prql-bot wants to merge 2 commits into
mainfrom
daily/review-runs-43178339935-cold-pull-request
Open

prql-bot wants to merge 2 commits into
mainfrom
daily/review-runs-43178339935-cold-pull-request

Conversation

@prql-bot

Copy link
Copy Markdown
Collaborator

AGENTS.md lists task prqlc:pull-request as the "before returning to user" check at about 30 seconds. From a cold target/, which is what every tend session starts with, it compiles all five bindings (test-all in prqlc/Taskfile.yaml) and then reruns the suite under cargo llvm-cov. That takes 10–30+ minutes. Sessions follow the instruction, wait on it, and then run the narrower suite anyway. This PR adds a note under the command: the 30-second figure assumes a warm build, and on a cold one task prqlc:test plus clippy on prqlc is enough before pushing, since CI runs the full suite.

It's a doc-only change. The note goes after the code block and leaves the heading line alone, so it doesn't overlap #6469's insertion just above. Whether CI sessions should skip the full task is the maintainer's call. If the preference is to keep running it, closing this is fine.

Evidence from nightly runs

All four outcomes were correct. The cost was runner time and session budget:

Earlier observations are in the review-runs tracking issues #6513 and #6394.

@prql-bot prql-bot added the review-runs Findings from tend-review-runs daily analysis label Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runs Findings from tend-review-runs daily analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant