[#71] 🐌 Slow connection detection#119
Draft
LahaLuhem wants to merge 4 commits intoOutdatedGuy:mainfrom
Hidden character warning
The head ref may contain hidden characters: "feature/99-\ud83d\udc0c-slow-connection-detection"
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #118 to implement #71.
Summary of changes
SlowConnectionConfigclassresponseTimefieldInternetConnection_checkReachabilityForto measure and record response timeinternetStatusgetter to check for slow connections when config is provided_internetStatusWithSlowDetectionStrict(): Checks if all endpoints are successful, then checks if any are slow_internetStatusWithSlowDetectionNonStrict(): Checks for any successful endpoint, returns connected if fast connection found, slow if only slow connections foundSummary of behaviour
This makes the final behaviour as follows
Left to do