Skip to content

Treat warnings as errors #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Otiel merged 3 commits into from
Nov 29, 2025
Merged

Treat warnings as errors #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a893ff7
Reorder csproj
Otiel Nov 29, 2025
146d610
Add Directory.Build.props to mutualize csproj properties
Otiel Nov 29, 2025
f0da2d7
Add TreatWarningsAsErrors
Otiel Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/Demo/Demo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,20 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<!-- Version -->
<VersionPrefix>1.0.0</VersionPrefix>
</PropertyGroup>

<PropertyGroup>
<!-- Assembly attributes -->
<AssemblyTitle>WpfMessageBoxDemo</AssemblyTitle>
<Description>Application used to demonstrate the capabilities of the WpfMessageBox</Description>
<Product>WpfMessageBoxDemo</Product>
<Copyright>ⓒ Otiel $([System.DateTime]::Now.Year)</Copyright>
</PropertyGroup>

<AppendPlatformToOutputPath>false</AppendPlatformToOutputPath>
<PropertyGroup>
<OutputType>WinExe</OutputType>
<TargetFrameworks>net48;net9.0-windows;net10.0-windows</TargetFrameworks>
<UseWPF>true</UseWPF>

<VersionPrefix>1.0.0</VersionPrefix>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Debug'">
<VersionSuffix>pre$([System.DateTime]::Now.ToString("yyyyMMdd-HHmmss"))</VersionSuffix>
</PropertyGroup>

<ItemGroup>
Expand Down
15 changes: 15 additions & 0 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<Project>

<PropertyGroup>
<Copyright>ⓒ Otiel $([System.DateTime]::Now.Year)</Copyright>
<AppendPlatformToOutputPath>false</AppendPlatformToOutputPath>
<TargetFrameworks>net48;net9.0-windows;net10.0-windows</TargetFrameworks>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Debug'">
<VersionSuffix>pre$([System.DateTime]::Now.ToString("yyyyMMdd-HHmmss"))</VersionSuffix>
</PropertyGroup>

</Project>
1 change: 1 addition & 0 deletions src/WpfMessageBox.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "SolutionItems", "SolutionIt
..\README.md = ..\README.md
..\.github\workflows\dotnet.yml = ..\.github\workflows\dotnet.yml
global.json = global.json
Directory.Build.props = Directory.Build.props
EndProjectSection
EndProject
Global
Expand Down
20 changes: 10 additions & 10 deletions src/WpfMessageBox/WpfMessageBox.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<!-- Version -->
<VersionPrefix>1.3.0</VersionPrefix>
</PropertyGroup>

<PropertyGroup>
<!-- Assembly attributes -->
<AssemblyTitle>WpfMessageBox</AssemblyTitle>
<Description>A WPF message box, with optional features like custom buttons, textbox and checkbox.</Description>
<Product>WpfMessageBox</Product>
<Copyright>ⓒ Otiel $([System.DateTime]::Now.Year)</Copyright>
</PropertyGroup>

<AppendPlatformToOutputPath>false</AppendPlatformToOutputPath>
<TargetFrameworks>net48;net9.0-windows;net10.0-windows</TargetFrameworks>
<PropertyGroup>
<UseWPF>true</UseWPF>

<VersionPrefix>1.3.0</VersionPrefix>

<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

<PropertyGroup>
<!-- Package properties -->
<PackageId>WpfMessageBox</PackageId>
<Authors>Otiel</Authors>
Expand All @@ -27,10 +31,6 @@
<PackageTags>wpf messagebox message box</PackageTags>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Debug'">
<VersionSuffix>pre$([System.DateTime]::Now.ToString("yyyyMMdd-HHmmss"))</VersionSuffix>
</PropertyGroup>

<ItemGroup>
<None Include="..\..\README.md" Pack="true" PackagePath="\" />
<None Include="..\..\docs\images\Icon.64x64.png" Pack="true" PackagePath="\" />
Expand Down